You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/13 05:52:07 UTC

[GitHub] [spark] HeartSaVioR edited a comment on issue #27834: [SPARK-31091] Revert SPARK-24640 Return `NULL` from `size(NULL)` by default

HeartSaVioR edited a comment on issue #27834: [SPARK-31091] Revert SPARK-24640 Return `NULL` from `size(NULL)` by default
URL: https://github.com/apache/spark/pull/27834#issuecomment-598559988
 
 
   Oh OK. I'm not sure I love to have `legacy` configurations which would lead end users to remember the old behavior (it would be nice to have its right name, and we can still control the behavior via default value), but given it has been one of the conventions, looks OK for now.
   
   One thing we may want to have attention is that, @ssimeonov did their own workaround while the behavior can be simply changed via touching the legacy config.
   
   @ssimeonov Did you indicate the existence of legacy config? If then, could you please elaborate why you didn't leverage the config? Thanks in advance!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org