You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "liferoad (via GitHub)" <gi...@apache.org> on 2024/05/20 19:55:10 UTC

[PR] Retry when the BQ job error can be retried [beam]

liferoad opened a new pull request, #31350:
URL: https://github.com/apache/beam/pull/31350

   From https://ge.apache.org/s/rwjhs7f4gc2ee/console-log/task/:sdks:python:test-suites:direct:py39:postCommitIT?anchor=424&page=1,
   
   ```
   
   [1mERROR    apache_beam.runners.common:bundle_processor.py:237 BigQuery job beam_bq_job_COPY_AUTOMATIC_JOB_NAME_COPY_STEP_76772e260e0c46cf96f0b94402c2595d_2af7745dca2d9060a22b202c77bbc2d8 failed. Error Result: <ErrorProto |  
   -- | --
     | message: 'Error encountered during execution. Retrying may solve the problem.' |  
     | reason: 'backendError'> [while running 'write/BigQueryBatchFileLoads/ParDo(TriggerCopyJobs)/ParDo(TriggerCopyJobs)']
   
   ```
   
   It looks like we should retry when this happens.
   
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
   
   To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Go tests](https://github.com/apache/beam/workflows/Go%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Retry when the BQ job error can be retried [beam]

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on code in PR #31350:
URL: https://github.com/apache/beam/pull/31350#discussion_r1608586066


##########
sdks/python/apache_beam/io/gcp/bigquery_tools.py:
##########
@@ -651,9 +651,19 @@ def wait_for_bq_job(self, job_reference, sleep_duration_sec=5, max_retries=0):
           job_reference.projectId, job_reference.jobId, job_reference.location)
       logging.info('Job %s status: %s', job.id, job.status.state)
       if job.status.state == 'DONE' and job.status.errorResult:
-        raise RuntimeError(
-            'BigQuery job {} failed. Error Result: {}'.format(
-                job_reference.jobId, job.status.errorResult))
+        if 'Retrying may solve the problem.' in job.status.errorResult.message:

Review Comment:
   So retry poll job when a job status returned DONE with errorResult, it won't actually retry the load job.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Retry when the BQ job error can be retried [beam]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #31350:
URL: https://github.com/apache/beam/pull/31350#issuecomment-2121164371

   Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment `assign set of reviewers`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Retry when the BQ job error can be retried [beam]

Posted by "liferoad (via GitHub)" <gi...@apache.org>.
liferoad closed pull request #31350: Retry when the BQ job error can be retried
URL: https://github.com/apache/beam/pull/31350


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Retry when the BQ job error can be retried [beam]

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on code in PR #31350:
URL: https://github.com/apache/beam/pull/31350#discussion_r1608584556


##########
sdks/python/apache_beam/io/gcp/bigquery_tools.py:
##########
@@ -651,9 +651,19 @@ def wait_for_bq_job(self, job_reference, sleep_duration_sec=5, max_retries=0):
           job_reference.projectId, job_reference.jobId, job_reference.location)
       logging.info('Job %s status: %s', job.id, job.status.state)
       if job.status.state == 'DONE' and job.status.errorResult:
-        raise RuntimeError(
-            'BigQuery job {} failed. Error Result: {}'.format(
-                job_reference.jobId, job.status.errorResult))
+        if 'Retrying may solve the problem.' in job.status.errorResult.message:

Review Comment:
   If I understood correctly, at this point the job is already completed as "DONE" and with error.
   
   self.get_job(...) is just a GET call to get. the BigQuery load job status. It won't retry the load job.
   
   The current retry logic is to poll existing job, and this poll API call can intermittently fail and get retried



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Retry when the BQ job error can be retried [beam]

Posted by "liferoad (via GitHub)" <gi...@apache.org>.
liferoad commented on code in PR #31350:
URL: https://github.com/apache/beam/pull/31350#discussion_r1608864456


##########
sdks/python/apache_beam/io/gcp/bigquery_tools.py:
##########
@@ -651,9 +651,19 @@ def wait_for_bq_job(self, job_reference, sleep_duration_sec=5, max_retries=0):
           job_reference.projectId, job_reference.jobId, job_reference.location)
       logging.info('Job %s status: %s', job.id, job.status.state)
       if job.status.state == 'DONE' and job.status.errorResult:
-        raise RuntimeError(
-            'BigQuery job {} failed. Error Result: {}'.format(
-                job_reference.jobId, job.status.errorResult))
+        if 'Retrying may solve the problem.' in job.status.errorResult.message:

Review Comment:
   Yes, you are right. Close this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org