You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by venkat sairam <ve...@gmail.com> on 2017/05/31 06:32:54 UTC
Review Request 59679: Hdfs directory viewer should be changed from
tree view to list view.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59679/
-----------------------------------------------------------
Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Nitiraj Rathore, Padma Priya N, Pallav Kulshreshtha, and Rohit Choudhary.
Bugs: AMBARI-21153
https://issues.apache.org/jira/browse/AMBARI-21153
Repository: ambari
Description
-------
Hdfs directory viewer have been changed from tree view to list view with added views.
Diffs
-----
contrib/views/commons/src/main/resources/ui/hdfs-directory-viewer/addon/components/directory-viewer.js 991d122
contrib/views/commons/src/main/resources/ui/hdfs-directory-viewer/addon/styles/app.css PRE-CREATION
contrib/views/commons/src/main/resources/ui/hdfs-directory-viewer/addon/templates/components/directory-viewer.hbs 75339c5
contrib/views/commons/src/main/resources/ui/hdfs-directory-viewer/addon/utils/viewer-config.js 64773c6
contrib/views/commons/src/main/resources/ui/hdfs-directory-viewer/bower.json f016904
contrib/views/commons/src/main/resources/ui/hdfs-directory-viewer/index.js dc074d7
contrib/views/commons/src/main/resources/ui/hdfs-directory-viewer/package.json 66a7b20
Diff: https://reviews.apache.org/r/59679/diff/1/
Testing
-------
Manual testing done.
Thanks,
venkat sairam
Re: Review Request 59679: Hdfs directory viewer should be changed
from tree view to list view.
Posted by venkat sairam <ve...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59679/
-----------------------------------------------------------
(Updated June 15, 2017, 10:50 a.m.)
Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Nitiraj Rathore, Padma Priya N, Pallav Kulshreshtha, and Rohit Choudhary.
Bugs: AMBARI-21153
https://issues.apache.org/jira/browse/AMBARI-21153
Repository: ambari
Description
-------
Hdfs directory viewer have been changed from tree view to list view with added views.
Diffs (updated)
-----
contrib/views/commons/src/main/resources/ui/hdfs-directory-viewer/addon/components/directory-viewer.js 991d122
contrib/views/commons/src/main/resources/ui/hdfs-directory-viewer/addon/styles/app.css PRE-CREATION
contrib/views/commons/src/main/resources/ui/hdfs-directory-viewer/addon/templates/components/directory-viewer.hbs 75339c5
contrib/views/commons/src/main/resources/ui/hdfs-directory-viewer/addon/utils/viewer-config.js 64773c6
contrib/views/commons/src/main/resources/ui/hdfs-directory-viewer/bower.json f016904
contrib/views/commons/src/main/resources/ui/hdfs-directory-viewer/index.js dc074d7
contrib/views/commons/src/main/resources/ui/hdfs-directory-viewer/package.json 66a7b20
Diff: https://reviews.apache.org/r/59679/diff/2/
Changes: https://reviews.apache.org/r/59679/diff/1-2/
Testing
-------
Manual testing done.
Thanks,
venkat sairam
Re: Review Request 59679: Hdfs directory viewer should be changed
from tree view to list view.
Posted by belliraj hb <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59679/#review176429
-----------------------------------------------------------
Ship it!
Ship It!
- belliraj hb
On May 31, 2017, 6:32 a.m., venkat sairam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59679/
> -----------------------------------------------------------
>
> (Updated May 31, 2017, 6:32 a.m.)
>
>
> Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Nitiraj Rathore, Padma Priya N, Pallav Kulshreshtha, and Rohit Choudhary.
>
>
> Bugs: AMBARI-21153
> https://issues.apache.org/jira/browse/AMBARI-21153
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Hdfs directory viewer have been changed from tree view to list view with added views.
>
>
> Diffs
> -----
>
> contrib/views/commons/src/main/resources/ui/hdfs-directory-viewer/addon/components/directory-viewer.js 991d122
> contrib/views/commons/src/main/resources/ui/hdfs-directory-viewer/addon/styles/app.css PRE-CREATION
> contrib/views/commons/src/main/resources/ui/hdfs-directory-viewer/addon/templates/components/directory-viewer.hbs 75339c5
> contrib/views/commons/src/main/resources/ui/hdfs-directory-viewer/addon/utils/viewer-config.js 64773c6
> contrib/views/commons/src/main/resources/ui/hdfs-directory-viewer/bower.json f016904
> contrib/views/commons/src/main/resources/ui/hdfs-directory-viewer/index.js dc074d7
> contrib/views/commons/src/main/resources/ui/hdfs-directory-viewer/package.json 66a7b20
>
>
> Diff: https://reviews.apache.org/r/59679/diff/1/
>
>
> Testing
> -------
>
> Manual testing done.
>
>
> Thanks,
>
> venkat sairam
>
>
Re: Review Request 59679: Hdfs directory viewer should be changed
from tree view to list view.
Posted by venkat sairam <ve...@gmail.com>.
> On June 2, 2017, 2:43 a.m., Pallav Kulshreshtha wrote:
> > contrib/views/commons/src/main/resources/ui/hdfs-directory-viewer/package.json
> > Lines 41 (patched)
> > <https://reviews.apache.org/r/59679/diff/1/?file=1735256#file1735256line41>
> >
> > Is there no specific version# for emeber colledction?
We have used this version to make this compatible with the plugins used in Files view.
- venkat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59679/#review176727
-----------------------------------------------------------
On May 31, 2017, 6:32 a.m., venkat sairam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59679/
> -----------------------------------------------------------
>
> (Updated May 31, 2017, 6:32 a.m.)
>
>
> Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Nitiraj Rathore, Padma Priya N, Pallav Kulshreshtha, and Rohit Choudhary.
>
>
> Bugs: AMBARI-21153
> https://issues.apache.org/jira/browse/AMBARI-21153
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Hdfs directory viewer have been changed from tree view to list view with added views.
>
>
> Diffs
> -----
>
> contrib/views/commons/src/main/resources/ui/hdfs-directory-viewer/addon/components/directory-viewer.js 991d122
> contrib/views/commons/src/main/resources/ui/hdfs-directory-viewer/addon/styles/app.css PRE-CREATION
> contrib/views/commons/src/main/resources/ui/hdfs-directory-viewer/addon/templates/components/directory-viewer.hbs 75339c5
> contrib/views/commons/src/main/resources/ui/hdfs-directory-viewer/addon/utils/viewer-config.js 64773c6
> contrib/views/commons/src/main/resources/ui/hdfs-directory-viewer/bower.json f016904
> contrib/views/commons/src/main/resources/ui/hdfs-directory-viewer/index.js dc074d7
> contrib/views/commons/src/main/resources/ui/hdfs-directory-viewer/package.json 66a7b20
>
>
> Diff: https://reviews.apache.org/r/59679/diff/1/
>
>
> Testing
> -------
>
> Manual testing done.
>
>
> Thanks,
>
> venkat sairam
>
>
Re: Review Request 59679: Hdfs directory viewer should be changed
from tree view to list view.
Posted by Pallav Kulshreshtha <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59679/#review176727
-----------------------------------------------------------
Fix it, then Ship it!
Ship It!
contrib/views/commons/src/main/resources/ui/hdfs-directory-viewer/package.json
Lines 41 (patched)
<https://reviews.apache.org/r/59679/#comment250178>
Is there no specific version# for emeber colledction?
- Pallav Kulshreshtha
On May 31, 2017, 6:32 a.m., venkat sairam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59679/
> -----------------------------------------------------------
>
> (Updated May 31, 2017, 6:32 a.m.)
>
>
> Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Nitiraj Rathore, Padma Priya N, Pallav Kulshreshtha, and Rohit Choudhary.
>
>
> Bugs: AMBARI-21153
> https://issues.apache.org/jira/browse/AMBARI-21153
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Hdfs directory viewer have been changed from tree view to list view with added views.
>
>
> Diffs
> -----
>
> contrib/views/commons/src/main/resources/ui/hdfs-directory-viewer/addon/components/directory-viewer.js 991d122
> contrib/views/commons/src/main/resources/ui/hdfs-directory-viewer/addon/styles/app.css PRE-CREATION
> contrib/views/commons/src/main/resources/ui/hdfs-directory-viewer/addon/templates/components/directory-viewer.hbs 75339c5
> contrib/views/commons/src/main/resources/ui/hdfs-directory-viewer/addon/utils/viewer-config.js 64773c6
> contrib/views/commons/src/main/resources/ui/hdfs-directory-viewer/bower.json f016904
> contrib/views/commons/src/main/resources/ui/hdfs-directory-viewer/index.js dc074d7
> contrib/views/commons/src/main/resources/ui/hdfs-directory-viewer/package.json 66a7b20
>
>
> Diff: https://reviews.apache.org/r/59679/diff/1/
>
>
> Testing
> -------
>
> Manual testing done.
>
>
> Thanks,
>
> venkat sairam
>
>