You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "MicroGery (via GitHub)" <gi...@apache.org> on 2024/04/23 08:49:08 UTC

[I] A bug when RocksDBDAO executes the prefixDelete function to delete the last entry [hudi]

MicroGery opened a new issue, #11075:
URL: https://github.com/apache/hudi/issues/11075

   https://github.com/apache/hudi/blob/8d6d9b98ac7df881e1b67c0dad80606bbe767fda/hudi-common/src/main/java/org/apache/hudi/common/util/collection/RocksDBDAO.java#L397
   Whether 
   getRocksDB().delete(lastEntry.getBytes()); 
   should be changed to 
   getRocksDB().delete(managedHandlesMap.get(columnFamilyName), lastEntry.getBytes());


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] A bug when RocksDBDAO executes the prefixDelete function to delete the last entry [hudi]

Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 closed issue #11075: A bug when RocksDBDAO executes the prefixDelete function to delete the last entry
URL: https://github.com/apache/hudi/issues/11075


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] A bug when RocksDBDAO executes the prefixDelete function to delete the last entry [hudi]

Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on issue #11075:
URL: https://github.com/apache/hudi/issues/11075#issuecomment-2074066196

   It looks reasonable, can you write some simple UT to demonstrate it?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] A bug when RocksDBDAO executes the prefixDelete function to delete the last entry [hudi]

Posted by "MicroGery (via GitHub)" <gi...@apache.org>.
MicroGery commented on issue #11075:
URL: https://github.com/apache/hudi/issues/11075#issuecomment-2136883919

   Of course, I was a bit busy recently, and now I’m looking into how to write unit tests.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] A bug when RocksDBDAO executes the prefixDelete function to delete the last entry [hudi]

Posted by "MicroGery (via GitHub)" <gi...@apache.org>.
MicroGery commented on issue #11075:
URL: https://github.com/apache/hudi/issues/11075#issuecomment-2073932313

   > Is this a bug from real production use case or just a code reviewing?
   
   Just a code reviewing


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] A bug when RocksDBDAO executes the prefixDelete function to delete the last entry [hudi]

Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on issue #11075:
URL: https://github.com/apache/hudi/issues/11075#issuecomment-2073782944

   Is this a bug from real production use case or just a code reviewing?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] A bug when RocksDBDAO executes the prefixDelete function to delete the last entry [hudi]

Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on issue #11075:
URL: https://github.com/apache/hudi/issues/11075#issuecomment-2229898912

   Fixed in https://github.com/apache/hudi/pull/11531


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org