You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "kgusakov (via GitHub)" <gi...@apache.org> on 2023/06/06 23:57:40 UTC
[GitHub] [ignite-3] kgusakov opened a new pull request, #2157: IGNITE-18692
kgusakov opened a new pull request, #2157:
URL: https://github.com/apache/ignite-3/pull/2157
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] sergeyuttsel commented on a diff in pull request #2157: IGNITE-18692 ItRebalanceTest fix
Posted by "sergeyuttsel (via GitHub)" <gi...@apache.org>.
sergeyuttsel commented on code in PR #2157:
URL: https://github.com/apache/ignite-3/pull/2157#discussion_r1226402939
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java:
##########
@@ -565,11 +571,17 @@ private CompletableFuture<?> onTableCreate(ConfigurationNotificationEvent<TableV
DistributionZoneView zone =
getZoneById(distributionZonesConfiguration, (ctx.newValue()).zoneId()).value();
- List<Set<Assignment>> assignments = AffinityUtils.calculateAssignments(
- // TODO: https://issues.apache.org/jira/browse/IGNITE-19425 use data nodes from DistributionZoneManager instead.
- baselineMgr.nodes().stream().map(ClusterNode::name).collect(toList()),
- zone.partitions(),
- zone.replicas());
+ List<Set<Assignment>> assignments;
+
+ if (partitionAssignments(vaultManager, ctx.newValue().id(), 0) != null) {
Review Comment:
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] kgusakov commented on a diff in pull request #2157: IGNITE-18692 ItRebalanceTest fix
Posted by "kgusakov (via GitHub)" <gi...@apache.org>.
kgusakov commented on code in PR #2157:
URL: https://github.com/apache/ignite-3/pull/2157#discussion_r1226381748
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java:
##########
@@ -565,11 +571,17 @@ private CompletableFuture<?> onTableCreate(ConfigurationNotificationEvent<TableV
DistributionZoneView zone =
getZoneById(distributionZonesConfiguration, (ctx.newValue()).zoneId()).value();
- List<Set<Assignment>> assignments = AffinityUtils.calculateAssignments(
- // TODO: https://issues.apache.org/jira/browse/IGNITE-19425 use data nodes from DistributionZoneManager instead.
- baselineMgr.nodes().stream().map(ClusterNode::name).collect(toList()),
- zone.partitions(),
- zone.replicas());
+ List<Set<Assignment>> assignments;
+
+ if (partitionAssignments(vaultManager, ctx.newValue().id(), 0) != null) {
Review Comment:
Added a comment. Not sure about the temporary or not, but in any case - if we already has assignments we shouldn't recalculate it again on recovery.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] sergeyuttsel commented on a diff in pull request #2157: IGNITE-18692 ItRebalanceTest fix
Posted by "sergeyuttsel (via GitHub)" <gi...@apache.org>.
sergeyuttsel commented on code in PR #2157:
URL: https://github.com/apache/ignite-3/pull/2157#discussion_r1224503073
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java:
##########
@@ -565,11 +571,17 @@ private CompletableFuture<?> onTableCreate(ConfigurationNotificationEvent<TableV
DistributionZoneView zone =
getZoneById(distributionZonesConfiguration, (ctx.newValue()).zoneId()).value();
- List<Set<Assignment>> assignments = AffinityUtils.calculateAssignments(
- // TODO: https://issues.apache.org/jira/browse/IGNITE-19425 use data nodes from DistributionZoneManager instead.
- baselineMgr.nodes().stream().map(ClusterNode::name).collect(toList()),
- zone.partitions(),
- zone.replicas());
+ List<Set<Assignment>> assignments;
+
+ if (partitionAssignments(vaultManager, ctx.newValue().id(), 0) != null) {
Review Comment:
Looks like some kind of magic. Please add a comment if possible. Is this a temporary or permanent solution? Getting nodes from zone manager will fix this or not?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] vldpyatkov merged pull request #2157: IGNITE-18692 ItRebalanceTest fix
Posted by "vldpyatkov (via GitHub)" <gi...@apache.org>.
vldpyatkov merged PR #2157:
URL: https://github.com/apache/ignite-3/pull/2157
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org