You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "alekseyolg (via GitHub)" <gi...@apache.org> on 2023/06/02 17:57:35 UTC
[GitHub] [superset] alekseyolg opened a new pull request, #24277: chore(docker): Add support LDAP/AD authorization
alekseyolg opened a new pull request, #24277:
URL: https://github.com/apache/superset/pull/24277
Add support LDAP/AD authorization
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [x] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] craig-rueda commented on pull request #24277: feat(docker): Add support LDAP/AD authorization
Posted by "craig-rueda (via GitHub)" <gi...@apache.org>.
craig-rueda commented on PR #24277:
URL: https://github.com/apache/superset/pull/24277#issuecomment-1591861453
@dpgaspar - do these libs look ok to you?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] craig-rueda commented on a diff in pull request #24277: feat(docker): Add support LDAP/AD authorization
Posted by "craig-rueda (via GitHub)" <gi...@apache.org>.
craig-rueda commented on code in PR #24277:
URL: https://github.com/apache/superset/pull/24277#discussion_r1218518004
##########
requirements/development.txt:
##########
@@ -10,6 +10,8 @@
# via
# -r requirements/base.in
# -r requirements/development.in
+Authlib==1.2.0
Review Comment:
These need to be added in `development.in`. After adding there, this file should be rebuilt according to the steps in `CONTRIBUTING.md`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] alekseyolg commented on a diff in pull request #24277: feat(docker): Add support LDAP/AD authorization
Posted by "alekseyolg (via GitHub)" <gi...@apache.org>.
alekseyolg commented on code in PR #24277:
URL: https://github.com/apache/superset/pull/24277#discussion_r1222039295
##########
requirements/development.txt:
##########
@@ -10,6 +10,8 @@
# via
# -r requirements/base.in
# -r requirements/development.in
+Authlib==1.2.0
Review Comment:
@craig-rueda Thanks for the tip, I've done all the steps!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] craig-rueda commented on pull request #24277: feat(docker): Add support LDAP/AD authorization
Posted by "craig-rueda (via GitHub)" <gi...@apache.org>.
craig-rueda commented on PR #24277:
URL: https://github.com/apache/superset/pull/24277#issuecomment-1600986914
Looks like oauthlib is still in the requirements. I think @dpgaspar mentioned that it wasn't necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] craig-rueda commented on a diff in pull request #24277: feat(docker): Add support LDAP/AD authorization
Posted by "craig-rueda (via GitHub)" <gi...@apache.org>.
craig-rueda commented on code in PR #24277:
URL: https://github.com/apache/superset/pull/24277#discussion_r1228380231
##########
requirements/development.in:
##########
@@ -18,9 +18,11 @@
#
-r base.in
-e .[cors,druid,hive,mysql,postgres,thumbnails]
+Authlib==1.2.0
Review Comment:
Unfortunately, we can't add `authlib` to superset as its license doesn't allow it. :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] alekseyolg commented on pull request #24277: feat(docker): Add support LDAP/AD authorization
Posted by "alekseyolg (via GitHub)" <gi...@apache.org>.
alekseyolg commented on PR #24277:
URL: https://github.com/apache/superset/pull/24277#issuecomment-1600064754
@craig-rueda Hello!
Are there any other suggestions to improve the code?
This code will be useful to many users!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] dpgaspar commented on a diff in pull request #24277: feat(docker): Add support LDAP/AD authorization
Posted by "dpgaspar (via GitHub)" <gi...@apache.org>.
dpgaspar commented on code in PR #24277:
URL: https://github.com/apache/superset/pull/24277#discussion_r1230174396
##########
requirements/development.txt:
##########
@@ -66,6 +64,8 @@ mccabe==0.6.1
# via pylint
mysqlclient==2.1.0
# via apache-superset
+oauthlib==3.2.2
Review Comment:
I don't think you need oauthlib for LDAP
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] alekseyolg commented on pull request #24277: feat(docker): Add support LDAP/AD authorization
Posted by "alekseyolg (via GitHub)" <gi...@apache.org>.
alekseyolg commented on PR #24277:
URL: https://github.com/apache/superset/pull/24277#issuecomment-1601539298
@craig-rueda Thanks for pointing out my mistake, apparently I forgot to add the appropriate commit.
This oversight has been corrected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] craig-rueda commented on a diff in pull request #24277: feat(docker): Add support LDAP/AD authorization
Posted by "craig-rueda (via GitHub)" <gi...@apache.org>.
craig-rueda commented on code in PR #24277:
URL: https://github.com/apache/superset/pull/24277#discussion_r1228380618
##########
requirements/development.txt:
##########
@@ -1,21 +1,21 @@
-# SHA1:6d10e2cb134133e823edef48aa3e33b2b1b85681
+# SHA1:bb993eaab64538deba5d9214b21e3f50251da50d
#
# This file is autogenerated by pip-compile-multi
# To update, run:
#
# pip-compile-multi
#
-r base.txt
--e file:.
+-e file:///tmp/superset
Review Comment:
This doesn't look right
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] alekseyolg commented on pull request #24277: feat(docker): Add support LDAP/AD authorization
Posted by "alekseyolg (via GitHub)" <gi...@apache.org>.
alekseyolg commented on PR #24277:
URL: https://github.com/apache/superset/pull/24277#issuecomment-1589564487
@craig-rueda Hello!
Please see the PR, I tried to make a useful suggestion!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] alekseyolg commented on a diff in pull request #24277: feat(docker): Add support LDAP/AD authorization
Posted by "alekseyolg (via GitHub)" <gi...@apache.org>.
alekseyolg commented on code in PR #24277:
URL: https://github.com/apache/superset/pull/24277#discussion_r1230444000
##########
requirements/development.txt:
##########
@@ -66,6 +64,8 @@ mccabe==0.6.1
# via pylint
mysqlclient==2.1.0
# via apache-superset
+oauthlib==3.2.2
Review Comment:
Thanks, I checked - this library is really not needed for ldap to work, after its removal, LDAP works correctly.
Removed from PR.
Thanks for the help!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] alekseyolg commented on a diff in pull request #24277: feat(docker): Add support LDAP/AD authorization
Posted by "alekseyolg (via GitHub)" <gi...@apache.org>.
alekseyolg commented on code in PR #24277:
URL: https://github.com/apache/superset/pull/24277#discussion_r1229000045
##########
requirements/development.txt:
##########
@@ -1,21 +1,21 @@
-# SHA1:6d10e2cb134133e823edef48aa3e33b2b1b85681
+# SHA1:bb993eaab64538deba5d9214b21e3f50251da50d
#
# This file is autogenerated by pip-compile-multi
# To update, run:
#
# pip-compile-multi
#
-r base.txt
--e file:.
+-e file:///tmp/superset
Review Comment:
@craig-rueda Thanks, this bug has been fixed!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] alekseyolg commented on pull request #24277: feat(docker): Add support LDAP/AD authorization
Posted by "alekseyolg (via GitHub)" <gi...@apache.org>.
alekseyolg commented on PR #24277:
URL: https://github.com/apache/superset/pull/24277#issuecomment-1590491360
@craig-rueda Hello!
All comments were promptly corrected!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] craig-rueda merged pull request #24277: feat(docker): Add support LDAP/AD authorization
Posted by "craig-rueda (via GitHub)" <gi...@apache.org>.
craig-rueda merged PR #24277:
URL: https://github.com/apache/superset/pull/24277
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] alekseyolg commented on pull request #24277: feat(docker): Add support LDAP/AD authorization
Posted by "alekseyolg (via GitHub)" <gi...@apache.org>.
alekseyolg commented on PR #24277:
URL: https://github.com/apache/superset/pull/24277#issuecomment-1596547723
Hello @dpgaspar! Thanks for your help writing this code!
If there are no more suggestions to improve our offer, then please give an approval for this pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] alekseyolg commented on a diff in pull request #24277: feat(docker): Add support LDAP/AD authorization
Posted by "alekseyolg (via GitHub)" <gi...@apache.org>.
alekseyolg commented on code in PR #24277:
URL: https://github.com/apache/superset/pull/24277#discussion_r1228999256
##########
requirements/development.in:
##########
@@ -18,9 +18,11 @@
#
-r base.in
-e .[cors,druid,hive,mysql,postgres,thumbnails]
+Authlib==1.2.0
Review Comment:
@craig-rueda Thanks for the note, the library has been replaced by oauthlib!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] alekseyolg commented on pull request #24277: feat(docker): Add support LDAP/AD authorization
Posted by "alekseyolg (via GitHub)" <gi...@apache.org>.
alekseyolg commented on PR #24277:
URL: https://github.com/apache/superset/pull/24277#issuecomment-1603052722
@craig-rueda Apparently, my code breaks the tests, if I correctly understood the principle of their work, then the last commit should solve the problem with the tests!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #24277: feat(docker): Add support LDAP/AD authorization
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #24277:
URL: https://github.com/apache/superset/pull/24277#issuecomment-1603233755
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/24277?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#24277](https://app.codecov.io/gh/apache/superset/pull/24277?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (4c2363e) into [master](https://app.codecov.io/gh/apache/superset/commit/1d9a761de5410fa1bd208bca4c78614779cf3064?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (1d9a761) will **decrease** coverage by `10.27%`.
> The diff coverage is `73.62%`.
> :exclamation: Current head 4c2363e differs from pull request most recent head c11344b. Consider uploading reports for the commit c11344b to get more accurate results
```diff
@@ Coverage Diff @@
## master #24277 +/- ##
===========================================
- Coverage 68.29% 58.02% -10.27%
===========================================
Files 1957 1901 -56
Lines 75624 74006 -1618
Branches 8223 8115 -108
===========================================
- Hits 51649 42944 -8705
- Misses 21867 28951 +7084
- Partials 2108 2111 +3
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| postgres | `?` | |
| presto | `53.79% <ø> (+0.47%)` | :arrow_up: |
| python | `60.59% <ø> (-22.19%)` | :arrow_down: |
| sqlite | `?` | |
| unit | `54.65% <ø> (+1.20%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://app.codecov.io/gh/apache/superset/pull/24277?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...ckages/superset-ui-chart-controls/src/constants.ts](https://app.codecov.io/gh/apache/superset/pull/24277?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbnN0YW50cy50cw==) | `100.00% <ø> (ø)` | |
| [...d/packages/superset-ui-chart-controls/src/types.ts](https://app.codecov.io/gh/apache/superset/pull/24277?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [...erset-ui-chart-controls/src/utils/columnChoices.ts](https://app.codecov.io/gh/apache/superset/pull/24277?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL3V0aWxzL2NvbHVtbkNob2ljZXMudHM=) | `100.00% <ø> (ø)` | |
| [...ges/superset-ui-core/src/query/buildQueryObject.ts](https://app.codecov.io/gh/apache/superset/pull/24277?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvcXVlcnkvYnVpbGRRdWVyeU9iamVjdC50cw==) | `100.00% <ø> (ø)` | |
| [...packages/superset-ui-core/src/query/types/Query.ts](https://app.codecov.io/gh/apache/superset/pull/24277?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvcXVlcnkvdHlwZXMvUXVlcnkudHM=) | `100.00% <ø> (ø)` | |
| [...set-ui-core/src/ui-overrides/ExtensionsRegistry.ts](https://app.codecov.io/gh/apache/superset/pull/24277?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdWktb3ZlcnJpZGVzL0V4dGVuc2lvbnNSZWdpc3RyeS50cw==) | `100.00% <ø> (ø)` | |
| [...acy-preset-chart-deckgl/src/components/Tooltip.tsx](https://app.codecov.io/gh/apache/superset/pull/24277?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcHJlc2V0LWNoYXJ0LWRlY2tnbC9zcmMvY29tcG9uZW50cy9Ub29sdGlwLnRzeA==) | `0.00% <0.00%> (ø)` | |
| [...preset-chart-deckgl/src/layers/Geojson/Geojson.jsx](https://app.codecov.io/gh/apache/superset/pull/24277?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcHJlc2V0LWNoYXJ0LWRlY2tnbC9zcmMvbGF5ZXJzL0dlb2pzb24vR2VvanNvbi5qc3g=) | `0.00% <0.00%> (ø)` | |
| [...et-chart-deckgl/src/layers/Geojson/controlPanel.ts](https://app.codecov.io/gh/apache/superset/pull/24277?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcHJlc2V0LWNoYXJ0LWRlY2tnbC9zcmMvbGF5ZXJzL0dlb2pzb24vY29udHJvbFBhbmVsLnRz) | `50.00% <ø> (ø)` | |
| [...preset-chart-deckgl/src/layers/Scatter/Scatter.jsx](https://app.codecov.io/gh/apache/superset/pull/24277?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcHJlc2V0LWNoYXJ0LWRlY2tnbC9zcmMvbGF5ZXJzL1NjYXR0ZXIvU2NhdHRlci5qc3g=) | `0.00% <0.00%> (ø)` | |
| ... and [51 more](https://app.codecov.io/gh/apache/superset/pull/24277?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [382 files with indirect coverage changes](https://app.codecov.io/gh/apache/superset/pull/24277/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org