You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2019/01/26 18:27:57 UTC
[GitHub] michael-o commented on a change in pull request #234: [MNG-6572] -
use int or long instead of BigIntegers for little numbers in
ComparableVersion
michael-o commented on a change in pull request #234: [MNG-6572] - use int or long instead of BigIntegers for little numbers in ComparableVersion
URL: https://github.com/apache/maven/pull/234#discussion_r251208223
##########
File path: maven-artifact/src/main/java/org/apache/maven/artifact/versioning/ComparableVersion.java
##########
@@ -359,7 +498,7 @@ public final void parseVersion( String version )
ListItem list = items;
- Stack<Item> stack = new Stack<>();
+ LinkedList<Item> stack = new LinkedList<>();
Review comment:
Don't use concrete types, interfaces on the lefthand side only.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services