You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "jpountz (via GitHub)" <gi...@apache.org> on 2023/08/04 22:21:02 UTC
[GitHub] [lucene] jpountz opened a new pull request, #12488: Stop aligning windows in BooleanScorer.
jpountz opened a new pull request, #12488:
URL: https://github.com/apache/lucene/pull/12488
BooleanScorer aligns windows to multiples of 2048, but it doesn't have to. Actually, not aligning windows can help evaluate fewer windows overall and speed up query evaluation.
This change speeds up counting `title OR 12` on wikimedium10m by ~18%.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] jpountz merged pull request #12488: Stop aligning windows in BooleanScorer.
Posted by "jpountz (via GitHub)" <gi...@apache.org>.
jpountz merged PR #12488:
URL: https://github.com/apache/lucene/pull/12488
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mikemccand commented on pull request #12488: Stop aligning windows in BooleanScorer.
Posted by "mikemccand (via GitHub)" <gi...@apache.org>.
mikemccand commented on PR #12488:
URL: https://github.com/apache/lucene/pull/12488#issuecomment-1666257665
Egads! That's an amazing gain!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] jpountz commented on pull request #12488: Stop aligning windows in BooleanScorer.
Posted by "jpountz (via GitHub)" <gi...@apache.org>.
jpountz commented on PR #12488:
URL: https://github.com/apache/lucene/pull/12488#issuecomment-1666447365
Counting tasks confirm the speedup:
```
TaskQPS baseline StdDevQPS my_modified_version StdDev Pct diff p-value
CountAndHighHigh 52.00 (4.3%) 51.84 (3.5%) -0.3% ( -7% - 7%) 0.809
CountAndHighMed 197.84 (3.6%) 197.39 (3.4%) -0.2% ( -6% - 7%) 0.839
PKLookup 242.74 (2.9%) 243.13 (3.1%) 0.2% ( -5% - 6%) 0.867
CountPhrase 12.55 (3.2%) 12.58 (3.8%) 0.2% ( -6% - 7%) 0.852
CountTerm 9032.87 (3.1%) 9142.12 (4.1%) 1.2% ( -5% - 8%) 0.292
CountOrHighMed 73.85 (12.7%) 81.64 (3.5%) 10.5% ( -4% - 30%) 0.000
CountOrHighHigh 46.92 (13.7%) 52.06 (3.9%) 11.0% ( -5% - 33%) 0.001
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] jpountz commented on pull request #12488: Stop aligning windows in BooleanScorer.
Posted by "jpountz (via GitHub)" <gi...@apache.org>.
jpountz commented on PR #12488:
URL: https://github.com/apache/lucene/pull/12488#issuecomment-1666957807
I realized I made a mistake in the benchmark, my baseline was a couple changes behind and probably missed #12475. I reran the benchmark correctly, and there is actually a small slowdown:
```
TaskQPS baseline StdDevQPS my_modified_version StdDev Pct diff p-value
CountOrHighHigh 50.49 (11.0%) 48.07 (12.0%) -4.8% ( -25% - 20%) 0.188
CountOrHighMed 79.22 (10.3%) 75.80 (11.4%) -4.3% ( -23% - 19%) 0.210
CountAndHighMed 195.82 (3.4%) 194.63 (4.3%) -0.6% ( -8% - 7%) 0.622
CountAndHighHigh 51.30 (3.8%) 51.16 (4.9%) -0.3% ( -8% - 8%) 0.851
CountPhrase 12.54 (2.5%) 12.54 (3.6%) -0.0% ( -6% - 6%) 0.996
CountTerm 9052.13 (3.3%) 9086.40 (3.3%) 0.4% ( -6% - 7%) 0.719
PKLookup 241.61 (3.3%) 243.34 (2.6%) 0.7% ( -5% - 6%) 0.449
```
I will revert.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org