[jira] [Commented] (TS-829) socks stats cleanup - some stats are registered, but not used

["Bryan Call (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TS-829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15421254#comment-15421254 ] 

Bryan Call commented on TS-829:
-------------------------------

[~tstroh]
Can you please get to this in the next 2 weeks (before 9/1)?  If not assign to me.

> socks stats cleanup - some stats are registered, but not used
> -------------------------------------------------------------
>
>                 Key: TS-829
>                 URL: https://issues.apache.org/jira/browse/TS-829
>             Project: Traffic Server
>          Issue Type: Improvement
>          Components: Network
>    Affects Versions: 3.0.0
>            Reporter: Bryan Call
>            Assignee: Tyler Stroh
>            Priority: Minor
>              Labels: incompatible
>             Fix For: 7.0.0
>
>
> From reviewing TS-818 I noticed that the stats that were being double resisted are not used.  Some cleanup work should be done for the socks stats.
> Stats that are registered, but not used in the code:
> [bcall@snowball traffic.git]$ grep -r proxy.process.socks iocore/net/Net.cc 
>                      "proxy.process.socks.connections_successful",
>                      "proxy.process.socks.connections_unsuccessful",
>                      "proxy.process.socks.connections_currently_open",
> These stats are used some tests, so maybe they should be added back into the code.
> [bcall@snowball traffic.git]$ grep -rl --binary-files=without-match proxy.process.socks.connections_ *
> iocore/net/Net.cc
> mgmt/api/remote/APITestCliRemote.cc
> test/plugin/test-mgmt/test-mgmt.c
> I did however see these stats being used:
> [bcall@snowball traffic.git]$ grep -r SOCKSPROXY_ *
> proxy/SocksProxy.cc:#define SOCKSPROXY_INC_STAT(x) \
> proxy/SocksProxy.cc:        SOCKSPROXY_INC_STAT(socksproxy_http_connections_stat);
> proxy/SocksProxy.cc:            SOCKSPROXY_INC_STAT(socksproxy_tunneled_connections_stat);



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)