You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/03/21 00:08:35 UTC
[GitHub] [camel-website] Gunkev opened a new pull request #249: added icons
ad rearranged packed with functionality section
Gunkev opened a new pull request #249: added icons ad rearranged packed with functionality section
URL: https://github.com/apache/camel-website/pull/249
In this PR added some icons to make the subject matter more comprehensible
# Initial website
# Changes made
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on a change in pull request
#249: added icons ad rearranged packed with functionality section
Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #249: added icons ad rearranged packed with functionality section
URL: https://github.com/apache/camel-website/pull/249#discussion_r400278979
##########
File path: antora-ui-camel/src/css/frontpage.css
##########
@@ -217,6 +218,12 @@ section.frontpage h1 {
width: 27rem;
}
+.packedFunctionalityIcon {
Review comment:
Needs to be scoped and use naming like in the rest of the CSS
```suggestion
.box .feature-icon {
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] Gunkev commented on a change in pull request #249:
added icons ad rearranged packed with functionality section
Posted by GitBox <gi...@apache.org>.
Gunkev commented on a change in pull request #249: added icons ad rearranged packed with functionality section
URL: https://github.com/apache/camel-website/pull/249#discussion_r397408008
##########
File path: antora-ui-camel/src/css/frontpage.css
##########
@@ -217,6 +222,10 @@ section.frontpage h1 {
width: 27rem;
}
+.icons8 {
+ width: 100px !important;
Review comment:
@zregvart yes i used this because images found on the home page have a default width of 27rem which is too big for that part. So I needed to add !important
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] Gunkev commented on issue #249: added icons ad
rearranged packed with functionality section
Posted by GitBox <gi...@apache.org>.
Gunkev commented on issue #249: added icons ad rearranged packed with functionality section
URL: https://github.com/apache/camel-website/pull/249#issuecomment-603466810
> We prefer SVG icons is there a chance these can be done in SVG. Are you using 3rd party icons, do we need to link or attribute their use, can you point to the license for these?
SVG are not free only PNG. should I consider using another Icon pack?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on a change in pull request
#249: added icons ad rearranged packed with functionality section
Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #249: added icons ad rearranged packed with functionality section
URL: https://github.com/apache/camel-website/pull/249#discussion_r397060107
##########
File path: antora-ui-camel/src/css/frontpage.css
##########
@@ -217,6 +222,10 @@ section.frontpage h1 {
width: 27rem;
}
+.icons8 {
+ width: 100px !important;
Review comment:
Is the use of `!important` here justified? Rules in this file need to be scoped to `.frontpage`. Not sure about `icons8` class name, can it be more descriptive of what it represents?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on issue #249: added icons ad
rearranged packed with functionality section
Posted by GitBox <gi...@apache.org>.
zregvart commented on issue #249: added icons ad rearranged packed with functionality section
URL: https://github.com/apache/camel-website/pull/249#issuecomment-607254644
This has been added to master in 7a638820be0e267b3e5f98aa0e671878ba3f0e05 and df79fdfbb370d7c0570167760211a576f62e7123
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] Gunkev commented on issue #249: added icons ad
rearranged packed with functionality section
Posted by GitBox <gi...@apache.org>.
Gunkev commented on issue #249: added icons ad rearranged packed with functionality section
URL: https://github.com/apache/camel-website/pull/249#issuecomment-603479008
> We prefer SVG icons is there a chance these can be done in SVG. Are you using 3rd party icons, do we need to link or attribute their use, can you point to the license for these?
We need to add link and here is the license https://icons8.com/license/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on a change in pull request
#249: added icons ad rearranged packed with functionality section
Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #249: added icons ad rearranged packed with functionality section
URL: https://github.com/apache/camel-website/pull/249#discussion_r398545815
##########
File path: antora-ui-camel/src/css/frontpage.css
##########
@@ -217,6 +218,11 @@ section.frontpage h1 {
width: 27rem;
}
+.evaIcons {
+ width: 60px !important;
Review comment:
Don't use pixel measure use a relative measure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] Gunkev commented on a change in pull request #249:
added icons ad rearranged packed with functionality section
Posted by GitBox <gi...@apache.org>.
Gunkev commented on a change in pull request #249: added icons ad rearranged packed with functionality section
URL: https://github.com/apache/camel-website/pull/249#discussion_r397416315
##########
File path: antora-ui-camel/src/css/frontpage.css
##########
@@ -188,6 +188,10 @@ section.frontpage h6 {
text-transform: uppercase;
}
+section.frontpage h2 {
+ font-size: 22px;
Review comment:
I think It will be better to use different heading format.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] Gunkev commented on issue #249: added icons ad
rearranged packed with functionality section
Posted by GitBox <gi...@apache.org>.
Gunkev commented on issue #249: added icons ad rearranged packed with functionality section
URL: https://github.com/apache/camel-website/pull/249#issuecomment-603539007
@zregvart I change the Icons type since it was not totally free. Now I'm using the open source [Eva icons](https://akveo.github.io/eva-icons/#/). here is how it look like
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on a change in pull request
#249: added icons ad rearranged packed with functionality section
Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #249: added icons ad rearranged packed with functionality section
URL: https://github.com/apache/camel-website/pull/249#discussion_r398544209
##########
File path: antora-ui-camel/src/css/frontpage.css
##########
@@ -217,6 +218,11 @@ section.frontpage h1 {
width: 27rem;
}
+.evaIcons {
Review comment:
I'd refrain from using `evaIcons`, these are icons that depict functionality so better name for them would be `functionality-icon` or similar. Read [this](https://www.w3.org/QA/Tips/goodclassnames).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on a change in pull request
#249: added icons ad rearranged packed with functionality section
Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #249: added icons ad rearranged packed with functionality section
URL: https://github.com/apache/camel-website/pull/249#discussion_r400308900
##########
File path: antora-ui-camel/src/css/vars.css
##########
@@ -21,6 +21,8 @@
--color-camel-orange: #ed8225;
--color-highlight: #fffcdd;
--color-glow: #fff7a3;
+ /* svg filter */
+ --filter-darkblue: invert(24%) sepia(38%) saturate(1353%) hue-rotate(200deg) brightness(89%) contrast(99%);
Review comment:
This doesn't need to be a variable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] Gunkev commented on issue #249: added icons ad
rearranged packed with functionality section
Posted by GitBox <gi...@apache.org>.
Gunkev commented on issue #249: added icons ad rearranged packed with functionality section
URL: https://github.com/apache/camel-website/pull/249#issuecomment-605090775
@zregvart I think everything is ok now
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on a change in pull request
#249: added icons ad rearranged packed with functionality section
Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #249: added icons ad rearranged packed with functionality section
URL: https://github.com/apache/camel-website/pull/249#discussion_r398547877
##########
File path: antora-ui-camel/src/css/frontpage.css
##########
@@ -217,6 +218,11 @@ section.frontpage h1 {
width: 27rem;
}
+.evaIcons {
+ width: 60px !important;
+ filter: invert(24%) sepia(38%) saturate(1353%) hue-rotate(200deg) brightness(89%) contrast(99%);
Review comment:
Couldn't we change the color in the icon, for other svg icons we style them with CSS using a technique described [here](https://css-tricks.com/cascading-svg-fill-color/). Have a look at this bit in CSS:
https://github.com/apache/camel-website/blob/3120c065b92dfca83059551d416a859134b89462/antora-ui-camel/src/css/header.css#L391-L396
And [this SVG file](https://github.com/apache/camel-website/blob/master/antora-ui-camel/src/img/brand-logos.svg?short_path=ec92056).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart closed pull request #249: added icons ad
rearranged packed with functionality section
Posted by GitBox <gi...@apache.org>.
zregvart closed pull request #249: added icons ad rearranged packed with functionality section
URL: https://github.com/apache/camel-website/pull/249
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on a change in pull request
#249: added icons ad rearranged packed with functionality section
Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #249: added icons ad rearranged packed with functionality section
URL: https://github.com/apache/camel-website/pull/249#discussion_r400306991
##########
File path: antora-ui-camel/src/css/frontpage.css
##########
@@ -217,6 +218,12 @@ section.frontpage h1 {
width: 27rem;
}
+.packedFunctionalityIcon {
+ width: 3.75rem !important;
+ height: 3.75rem !important;
Review comment:
don't use `!important` scope the rule more precisely, like above
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on issue #249: added icons ad
rearranged packed with functionality section
Posted by GitBox <gi...@apache.org>.
zregvart commented on issue #249: added icons ad rearranged packed with functionality section
URL: https://github.com/apache/camel-website/pull/249#issuecomment-603170286
Preview is [here](https://builds.apache.org/job/Camel.website/job/PR-249/Preview/index.html).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] Gunkev commented on a change in pull request #249:
added icons ad rearranged packed with functionality section
Posted by GitBox <gi...@apache.org>.
Gunkev commented on a change in pull request #249: added icons ad rearranged packed with functionality section
URL: https://github.com/apache/camel-website/pull/249#discussion_r397414811
##########
File path: antora-ui-camel/src/css/frontpage.css
##########
@@ -217,6 +222,10 @@ section.frontpage h1 {
width: 27rem;
}
+.icons8 {
+ width: 100px !important;
Review comment:
About icons8 it's the name for this Icon types. Actually I used Icons8 types. Only png types from 1px to 100px are free. SVG are not free. Should I consider using another Icon type ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on a change in pull request
#249: added icons ad rearranged packed with functionality section
Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #249: added icons ad rearranged packed with functionality section
URL: https://github.com/apache/camel-website/pull/249#discussion_r397059175
##########
File path: antora-ui-camel/src/css/frontpage.css
##########
@@ -188,6 +188,10 @@ section.frontpage h6 {
text-transform: uppercase;
}
+section.frontpage h2 {
+ font-size: 22px;
Review comment:
We should either use a different heading in the markup (like h3 instead of h2), or change the `px` to `rem` here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services