You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by Renkai <gi...@git.apache.org> on 2015/09/02 07:46:44 UTC
[GitHub] storm pull request: [STORM-1005]replace default storm.local.dir va...
GitHub user Renkai opened a pull request:
https://github.com/apache/storm/pull/713
[STORM-1005]replace default storm.local.dir value to absolute path.
One of my supervisors shutdown by it self after running for a few weeks.After I restart the supervisor from another directory(actually I don't remember which directory I started the supervisor at first.Then the workers running on that machine become wild.They running as usual,but the supervisor can't detect them,and I can't shutdown them with `storm kill`.When I submit a new topology,the supervisor will try to start new a worker with the port running workers already used,it will cause failure.
It's hard form a typical user to know why such exception happens,so I think it's better to set storm.local.dir as a absolute path.
If `storm.local.dir` can be set to `$STORM_HOME/storm-local`,it may be best.But it seems yaml file only support constant values.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Renkai/storm storm-1005
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/713.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #713
----
commit cb2f9f54aaec7ff43ee7c96d991b12de4c689168
Author: renkai <ga...@gmail.com>
Date: 2015-09-02T05:26:43Z
replace default storm.local.dir value to absolute path.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1005]replace default storm.local.dir va...
Posted by Renkai <gi...@git.apache.org>.
Github user Renkai commented on the pull request:
https://github.com/apache/storm/pull/713#issuecomment-137371641
If make storm.local.dir to a relative path is better,how about make the path relative to where storm is installed rather than where user start the storm processes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1005]replace default storm.local.dir va...
Posted by Renkai <gi...@git.apache.org>.
Github user Renkai closed the pull request at:
https://github.com/apache/storm/pull/713
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1005]replace default storm.local.dir va...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/713#issuecomment-137288071
One thing we should keep in mind is, some users are using Storm in Windows environment.
Using absolute path, especially known *nix path to default value will make a problem for those users.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1005]replace default storm.local.dir va...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/713#issuecomment-137568073
Sounds good for me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1005]replace default storm.local.dir va...
Posted by erikdw <gi...@git.apache.org>.
Github user erikdw commented on a diff in the pull request:
https://github.com/apache/storm/pull/713#discussion_r39913602
--- Diff: docs/documentation/Setting-up-a-Storm-cluster.md ---
@@ -52,10 +52,13 @@ storm.zookeeper.servers:
If the port that your Zookeeper cluster uses is different than the default, you should set **storm.zookeeper.port** as well.
-2) **storm.local.dir**: The Nimbus and Supervisor daemons require a directory on the local disk to store small amounts of state (like jars, confs, and things like that). You should create that directory on each machine, give it proper permissions, and then fill in the directory location using this config. For example:
+2) **storm.local.dir**: The Nimbus and Supervisor daemons require a directory on the local disk to store small amounts of state (like jars, confs, and things like that).
+ You should create that directory on each machine, give it proper permissions, and then fill in the directory location using this config.
+ You'd better set it to absolute path rather than relative path,otherwise it will cause unexpected behavior when you launch daemons
+ from different directories.For example:
--- End diff --
space between . and For
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---