You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/10/10 16:30:08 UTC
[GitHub] [airflow] potiuk opened a new pull request #11403: Fixes cancelling of too many workflows.
potiuk opened a new pull request #11403:
URL: https://github.com/apache/airflow/pull/11403
A problem was introduced in #11397 where a bit too many "Build Image"
jobs is being cancelled by subsequent Build Image run. For now it
cancels all the Build Image jobs that are running :(.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dimberman commented on pull request #11403: Fixes cancelling of too many workflows.
Posted by GitBox <gi...@apache.org>.
dimberman commented on pull request #11403:
URL: https://github.com/apache/airflow/pull/11403#issuecomment-706577850
My pleasure!
Ugh between this and the fact we need to restart all jobs for single failures, github actions is becoming a "lesser of evils" rather than an optimal product.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #11403: Fixes cancelling of too many workflows.
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #11403:
URL: https://github.com/apache/airflow/pull/11403#issuecomment-706576575
Issue opened to GitHub support to change this behaviour. It is really annoying and it has bitten me too many times already .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #11403: Fixes cancelling of too many workflows.
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #11403:
URL: https://github.com/apache/airflow/pull/11403
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #11403: Fixes cancelling of too many workflows.
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #11403:
URL: https://github.com/apache/airflow/pull/11403#issuecomment-706575721
Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dimberman commented on pull request #11403: Fixes cancelling of too many workflows.
Posted by GitBox <gi...@apache.org>.
dimberman commented on pull request #11403:
URL: https://github.com/apache/airflow/pull/11403#issuecomment-706575511
@potiuk I'm around. Glad to reveiw.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #11403: Fixes cancelling of too many workflows.
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #11403:
URL: https://github.com/apache/airflow/pull/11403#issuecomment-706586814
Yeah. It's highly and easily customisable which is good but also "move fast and break things"
Here I keep track of all the issues with GitHub Actionns I opened "Apache Enterprise Support" level tickets for https://github.com/apache/airflow/issues/11294
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #11403: Fixes cancelling of too many workflows.
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #11403:
URL: https://github.com/apache/airflow/pull/11403#issuecomment-706575378
This one is pretty urgent :(. I made a mistake and now any new build image will cancel all the other ones :(.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #11403: Fixes cancelling of too many workflows.
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #11403:
URL: https://github.com/apache/airflow/pull/11403#issuecomment-706575956
Basically it's how GA handles mistakes in task names - rather than failing, they replace it with "" ... and in this case that resulted with "Cancel any job that has any name matching with "Source Run Id: ". All of them matched :(.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org