You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2019/08/02 11:29:54 UTC

[GitHub] [hadoop] ChenSammi commented on a change in pull request #1184: HDDS-1865. Use "ozone.network.topology.aware.read" to control both RPC client and server side logic

ChenSammi commented on a change in pull request #1184: HDDS-1865. Use "ozone.network.topology.aware.read" to control both RPC client and server side logic
URL: https://github.com/apache/hadoop/pull/1184#discussion_r310091612
 
 

 ##########
 File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/placement/algorithms/ContainerPlacementPolicyFactory.java
 ##########
 @@ -36,7 +36,7 @@
 
   private static final Class<? extends ContainerPlacementPolicy>
       OZONE_SCM_CONTAINER_PLACEMENT_IMPL_DEFAULT =
-      SCMContainerPlacementRandom.class;
+      SCMContainerPlacementRackAware.class;
 
 Review comment:
   ContainerPlacementPolicy chosen  and topology aware read are two independent choice. If  SCMContainerPlacementRandom is used, we can still enable topology aware read as long as datanode to network location mapping is correctly built.  
   This change is committed unintentionally, I will remove it now, and enable the configuration after 0.4.1 is released. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org