You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Konstantin Shvachko (JIRA)" <ji...@apache.org> on 2009/04/03 00:11:13 UTC
[jira] Created: (HADOOP-5619) Convert FSImage.removedStorageDirs
into a map.
Convert FSImage.removedStorageDirs into a map.
----------------------------------------------
Key: HADOOP-5619
URL: https://issues.apache.org/jira/browse/HADOOP-5619
Project: Hadoop Core
Issue Type: Improvement
Components: dfs
Affects Versions: 0.21.0
Reporter: Konstantin Shvachko
Fix For: 0.21.0
{{FSImage.removedStorageDirs}} is declared as an {{ArrayList}}. In order to avoid adding the same directory twice into {{removedStorageDirs}} we should convert it into a map.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5619) Convert FSImage.removedStorageDirs
into a map.
Posted by "ZhuGuanyin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ZhuGuanyin updated HADOOP-5619:
-------------------------------
Attachment: encode-free-KeyFieldBasedPartitioner-v1.patch
create patch using svn diff
> Convert FSImage.removedStorageDirs into a map.
> ----------------------------------------------
>
> Key: HADOOP-5619
> URL: https://issues.apache.org/jira/browse/HADOOP-5619
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Affects Versions: 0.21.0
> Reporter: Konstantin Shvachko
> Assignee: Boris Shkolnik
> Fix For: 0.21.0
>
> Attachments: HADOOP-5619.patch
>
>
> {{FSImage.removedStorageDirs}} is declared as an {{ArrayList}}. In order to avoid adding the same directory twice into {{removedStorageDirs}} we should convert it into a map.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5619) Convert FSImage.removedStorageDirs
into a map.
Posted by "Konstantin Shvachko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12705111#action_12705111 ]
Konstantin Shvachko commented on HADOOP-5619:
---------------------------------------------
# {{removedStorageDirs}} should be declared as an interface {{Map<>}} rather than a class {{TreeMap<>}}.
# Same with {{getRemovedStorageDirs()}} - it should return an interface.
# Could you please verify whether can avoid initializing it in declaration section. It would be better not to.
# Please fix warnings in the import section. Also I don't think changing of the order of includes is necessary.
# What about test failures?
> Convert FSImage.removedStorageDirs into a map.
> ----------------------------------------------
>
> Key: HADOOP-5619
> URL: https://issues.apache.org/jira/browse/HADOOP-5619
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Affects Versions: 0.21.0
> Reporter: Konstantin Shvachko
> Assignee: Boris Shkolnik
> Fix For: 0.21.0
>
> Attachments: HADOOP-5619.patch
>
>
> {{FSImage.removedStorageDirs}} is declared as an {{ArrayList}}. In order to avoid adding the same directory twice into {{removedStorageDirs}} we should convert it into a map.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5619) Convert FSImage.removedStorageDirs
into a map.
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12698587#action_12698587 ]
Hadoop QA commented on HADOOP-5619:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12405199/HADOOP-5619.patch
against trunk revision 764287.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 Eclipse classpath. The patch retains Eclipse classpath integrity.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
-1 contrib tests. The patch failed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/192/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/192/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/192/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/192/console
This message is automatically generated.
> Convert FSImage.removedStorageDirs into a map.
> ----------------------------------------------
>
> Key: HADOOP-5619
> URL: https://issues.apache.org/jira/browse/HADOOP-5619
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Affects Versions: 0.21.0
> Reporter: Konstantin Shvachko
> Assignee: Boris Shkolnik
> Fix For: 0.21.0
>
> Attachments: HADOOP-5619.patch
>
>
> {{FSImage.removedStorageDirs}} is declared as an {{ArrayList}}. In order to avoid adding the same directory twice into {{removedStorageDirs}} we should convert it into a map.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HADOOP-5619) Convert FSImage.removedStorageDirs
into a map.
Posted by "Boris Shkolnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Boris Shkolnik reassigned HADOOP-5619:
--------------------------------------
Assignee: Boris Shkolnik (was: Jakob Homan)
> Convert FSImage.removedStorageDirs into a map.
> ----------------------------------------------
>
> Key: HADOOP-5619
> URL: https://issues.apache.org/jira/browse/HADOOP-5619
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Affects Versions: 0.21.0
> Reporter: Konstantin Shvachko
> Assignee: Boris Shkolnik
> Fix For: 0.21.0
>
>
> {{FSImage.removedStorageDirs}} is declared as an {{ArrayList}}. In order to avoid adding the same directory twice into {{removedStorageDirs}} we should convert it into a map.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5619) Convert FSImage.removedStorageDirs
into a map.
Posted by "ZhuGuanyin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ZhuGuanyin updated HADOOP-5619:
-------------------------------
Attachment: (was: encode-free-KeyFieldBasedPartitioner-v1.patch)
> Convert FSImage.removedStorageDirs into a map.
> ----------------------------------------------
>
> Key: HADOOP-5619
> URL: https://issues.apache.org/jira/browse/HADOOP-5619
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Affects Versions: 0.21.0
> Reporter: Konstantin Shvachko
> Assignee: Boris Shkolnik
> Fix For: 0.21.0
>
> Attachments: HADOOP-5619.patch
>
>
> {{FSImage.removedStorageDirs}} is declared as an {{ArrayList}}. In order to avoid adding the same directory twice into {{removedStorageDirs}} we should convert it into a map.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5619) Convert FSImage.removedStorageDirs
into a map.
Posted by "Boris Shkolnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Boris Shkolnik updated HADOOP-5619:
-----------------------------------
Attachment: HADOOP-5619.patch
> Convert FSImage.removedStorageDirs into a map.
> ----------------------------------------------
>
> Key: HADOOP-5619
> URL: https://issues.apache.org/jira/browse/HADOOP-5619
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Affects Versions: 0.21.0
> Reporter: Konstantin Shvachko
> Assignee: Boris Shkolnik
> Fix For: 0.21.0
>
> Attachments: HADOOP-5619.patch
>
>
> {{FSImage.removedStorageDirs}} is declared as an {{ArrayList}}. In order to avoid adding the same directory twice into {{removedStorageDirs}} we should convert it into a map.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HADOOP-5619) Convert FSImage.removedStorageDirs
into a map.
Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jakob Homan reassigned HADOOP-5619:
-----------------------------------
Assignee: Jakob Homan
> Convert FSImage.removedStorageDirs into a map.
> ----------------------------------------------
>
> Key: HADOOP-5619
> URL: https://issues.apache.org/jira/browse/HADOOP-5619
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Affects Versions: 0.21.0
> Reporter: Konstantin Shvachko
> Assignee: Jakob Homan
> Fix For: 0.21.0
>
>
> {{FSImage.removedStorageDirs}} is declared as an {{ArrayList}}. In order to avoid adding the same directory twice into {{removedStorageDirs}} we should convert it into a map.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5619) Convert FSImage.removedStorageDirs
into a map.
Posted by "Boris Shkolnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Boris Shkolnik updated HADOOP-5619:
-----------------------------------
Status: Open (was: Patch Available)
> Convert FSImage.removedStorageDirs into a map.
> ----------------------------------------------
>
> Key: HADOOP-5619
> URL: https://issues.apache.org/jira/browse/HADOOP-5619
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Affects Versions: 0.21.0
> Reporter: Konstantin Shvachko
> Assignee: Boris Shkolnik
> Fix For: 0.21.0
>
> Attachments: HADOOP-5619.patch
>
>
> {{FSImage.removedStorageDirs}} is declared as an {{ArrayList}}. In order to avoid adding the same directory twice into {{removedStorageDirs}} we should convert it into a map.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5619) Convert FSImage.removedStorageDirs
into a map.
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12698236#action_12698236 ]
Hadoop QA commented on HADOOP-5619:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12405199/HADOOP-5619.patch
against trunk revision 764287.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 Eclipse classpath. The patch retains Eclipse classpath integrity.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
-1 contrib tests. The patch failed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/184/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/184/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/184/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/184/console
This message is automatically generated.
> Convert FSImage.removedStorageDirs into a map.
> ----------------------------------------------
>
> Key: HADOOP-5619
> URL: https://issues.apache.org/jira/browse/HADOOP-5619
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Affects Versions: 0.21.0
> Reporter: Konstantin Shvachko
> Assignee: Boris Shkolnik
> Fix For: 0.21.0
>
> Attachments: HADOOP-5619.patch
>
>
> {{FSImage.removedStorageDirs}} is declared as an {{ArrayList}}. In order to avoid adding the same directory twice into {{removedStorageDirs}} we should convert it into a map.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5619) Convert FSImage.removedStorageDirs
into a map.
Posted by "Boris Shkolnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Boris Shkolnik updated HADOOP-5619:
-----------------------------------
Status: Patch Available (was: Open)
also added listAllStorages method in fsimage for better future debugging of the related issues.
> Convert FSImage.removedStorageDirs into a map.
> ----------------------------------------------
>
> Key: HADOOP-5619
> URL: https://issues.apache.org/jira/browse/HADOOP-5619
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Affects Versions: 0.21.0
> Reporter: Konstantin Shvachko
> Assignee: Boris Shkolnik
> Fix For: 0.21.0
>
> Attachments: HADOOP-5619.patch
>
>
> {{FSImage.removedStorageDirs}} is declared as an {{ArrayList}}. In order to avoid adding the same directory twice into {{removedStorageDirs}} we should convert it into a map.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5619) Convert FSImage.removedStorageDirs
into a map.
Posted by "Boris Shkolnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Boris Shkolnik updated HADOOP-5619:
-----------------------------------
Status: Patch Available (was: Open)
no new test - this is a data structure change, it should be covered by existing tests
test failures seem unrelated. It also looks like some other process was running which cased multiple failures. I am going to resubmit this patch to verify.
> Convert FSImage.removedStorageDirs into a map.
> ----------------------------------------------
>
> Key: HADOOP-5619
> URL: https://issues.apache.org/jira/browse/HADOOP-5619
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Affects Versions: 0.21.0
> Reporter: Konstantin Shvachko
> Assignee: Boris Shkolnik
> Fix For: 0.21.0
>
> Attachments: HADOOP-5619.patch
>
>
> {{FSImage.removedStorageDirs}} is declared as an {{ArrayList}}. In order to avoid adding the same directory twice into {{removedStorageDirs}} we should convert it into a map.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.