You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2024/09/16 22:39:32 UTC
[kudu-CR] WIP [tablet] edge case scenario for major delta compaction
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21809
Change subject: WIP [tablet] edge case scenario for major delta compaction
......................................................................
WIP [tablet] edge case scenario for major delta compaction
KUDU-3465 pointed at an edge case in major delta compaction,
but due to the stochastic nature of the UpdateNoMergeCompaction
test, it was perceived as a flakiness.
This patch adds a test to reproduce the failure with 100% certainty.
Other minor updates on major_delta_compaction-test.cc are included,
but maybe they should be separated in their own patch.
NOTE:
the test is disabled for now in this WIP patch; One the issue
is addressed, it should be re-enabled.
WIP:
* address the issue and re-enable the newly added test
* move the unrelated updates in a separate patch
Change-Id: I3cb9e2a4055b2ab114482656acb0d0fc73864635
---
M src/kudu/tablet/major_delta_compaction-test.cc
1 file changed, 43 insertions(+), 11 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/09/21809/1
--
To view, visit http://gerrit.cloudera.org:8080/21809
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3cb9e2a4055b2ab114482656acb0d0fc73864635
Gerrit-Change-Number: 21809
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
[kudu-CR] WIP [tablet] edge case scenario for major delta compaction
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21809 )
Change subject: WIP [tablet] edge case scenario for major delta compaction
......................................................................
Patch Set 2:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/519/
--
To view, visit http://gerrit.cloudera.org:8080/21809
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3cb9e2a4055b2ab114482656acb0d0fc73864635
Gerrit-Change-Number: 21809
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 16 Sep 2024 23:56:46 +0000
Gerrit-HasComments: No
[kudu-CR] WIP [tablet] edge case scenario for major delta compaction
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21809 )
Change subject: WIP [tablet] edge case scenario for major delta compaction
......................................................................
Patch Set 1: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/517/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/21809
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3cb9e2a4055b2ab114482656acb0d0fc73864635
Gerrit-Change-Number: 21809
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 16 Sep 2024 23:35:59 +0000
Gerrit-HasComments: No
[kudu-CR] WIP [tablet] edge case scenario for major delta compaction
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21809 )
Change subject: WIP [tablet] edge case scenario for major delta compaction
......................................................................
Patch Set 1:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/517/
--
To view, visit http://gerrit.cloudera.org:8080/21809
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3cb9e2a4055b2ab114482656acb0d0fc73864635
Gerrit-Change-Number: 21809
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 16 Sep 2024 22:39:40 +0000
Gerrit-HasComments: No
[kudu-CR] WIP [tablet] edge case scenario for major delta compaction
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21809 )
Change subject: WIP [tablet] edge case scenario for major delta compaction
......................................................................
Patch Set 2: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/519/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/21809
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3cb9e2a4055b2ab114482656acb0d0fc73864635
Gerrit-Change-Number: 21809
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 17 Sep 2024 02:33:41 +0000
Gerrit-HasComments: No
[kudu-CR] WIP [tablet] edge case scenario for major delta compaction
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Abhishek Chennaka,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21809
to look at the new patch set (#2).
Change subject: WIP [tablet] edge case scenario for major delta compaction
......................................................................
WIP [tablet] edge case scenario for major delta compaction
KUDU-3465 pointed at an edge case in major delta compaction,
but due to the stochastic nature of the UpdateNoMergeCompaction
test, it was perceived as a flakiness.
This patch adds a test to reproduce the failure with 100% certainty.
Other minor updates on major_delta_compaction-test.cc are included,
but maybe they should be separated in their own patch.
NOTE:
the test is disabled for now in this WIP patch; One the issue
is addressed, it should be re-enabled.
WIP:
* address the issue and re-enable the newly added test
* move the unrelated updates in a separate patch
Change-Id: I3cb9e2a4055b2ab114482656acb0d0fc73864635
---
M src/kudu/tablet/major_delta_compaction-test.cc
1 file changed, 47 insertions(+), 12 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/09/21809/2
--
To view, visit http://gerrit.cloudera.org:8080/21809
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3cb9e2a4055b2ab114482656acb0d0fc73864635
Gerrit-Change-Number: 21809
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)