[GitHub] khmarbaise commented on a change in pull request #176: Fix to prevent warning due to CI-friendly version in the parent pom

[GitBox <gi...@apache.org>]

khmarbaise commented on a change in pull request #176: Fix to prevent warning due to CI-friendly version in the parent pom
URL: https://github.com/apache/maven/pull/176#discussion_r217950350
 
 

 ##########
 File path: maven-core/src/main/java/org/apache/maven/project/DefaultProjectBuilder.java
 ##########
 @@ -669,6 +669,9 @@ private void initProject( MavenProject project, Map<String, MavenProject> projec
                 else
                 {
                     Artifact parentArtifact = project.getParentArtifact();
+                    if (parentArtifact.getVersion().matches("\\$\\{(revision|sha1|changelist)}")) {
+                        parentArtifact.setVersion(project.getModel().getParent().getVersion());
 
 Review comment:
   First the pattern is not enough if we really allow to use ci friendly in parent cause things like this `${revision}-${changelist}` are also possible which will not work with this pattern..Furthermore an integration test is needed for such things. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services