[jira] [Commented] (CALCITE-2443) Ability to pass ClientCache object to GeodeSchema constructor

["Julian Hyde (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-2443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16568462#comment-16568462 ] 

Julian Hyde commented on CALCITE-2443:
--------------------------------------

We generally don’t pass objects that are not value objects (think: JSON) to schema constructors.

If you need richer objects inside the schema maybe pass a URI then get the real object inside the schema using s JNDI directory service. Or something.

> Ability to pass ClientCache object to GeodeSchema constructor
> -------------------------------------------------------------
>
>                 Key: CALCITE-2443
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2443
>             Project: Calcite
>          Issue Type: Improvement
>          Components: geode
>            Reporter: Sandeep Chada
>            Assignee: Julian Hyde
>            Priority: Major
>
> Would like to create a new Constructor inside GeodeSchema that takes in the clientCache as a parameter. 
> We have a use case where the creation of geode clientCache is done in a separate api library.
> This the change I am proposing
> public GeodeSchema(String locatorHost, int locatorPort,
>  String[] regionNames, String pdxAutoSerializerPackageExp,
>  SchemaPlus parentSchema) {
>  this(regionNames,createClientCache(locatorHost, locatorPort,
>  pdxAutoSerializerPackageExp, true) ,parentSchema);
> }
> public GeodeSchema(String[] regionNames, ClientCache clientCache, SchemaPlus parentSchema) {
>  super();
>  this.regionNames = regionNames;
>  this.parentSchema = parentSchema;
>  this.clientCache = clientCache;
> }
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)