[jira] [Commented] (GEODE-749) Improve detection of *.war files

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15107662#comment-15107662 ] 

ASF GitHub Bot commented on GEODE-749:
--------------------------------------

GitHub user jinmeiliao opened a pull request:

    https://github.com/apache/incubator-geode/pull/73

    GEODE-749: refactor the code to look for the war file in multiple pla…

    …ces w/o version number and look for them in the classpath as well.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jinmeiliao/incubator-geode feature/GEODE-749

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-geode/pull/73.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #73
    
----
commit dbdea31e0f8799775e68e04af0b92038d26121b7
Author: Jinmei Liao <ji...@pivotal.io>
Date:   2016-01-19T23:16:06Z

    GEODE-749: refactor the code to look for the war file in multiple places w/o version number and look for them in the classpath as well.

----


> Improve detection of *.war files
> --------------------------------
>
>                 Key: GEODE-749
>                 URL: https://issues.apache.org/jira/browse/GEODE-749
>             Project: Geode
>          Issue Type: Improvement
>          Components: management
>            Reporter: Jens Deppe
>
> Currently we require a GEMFIRE environment variable to be set in order to detect the location of the pulse.war (and newly) the gemfire.war file.
> I believe this requirement could be avoided by looking for the relevant war file as a resource on the classpath.
> If a user is building a self-contained (possibly executable) application jar, containing all the relevant gemfire jars, they would still need to provide an external pulse.war file as well as set the env variable during execution. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)