You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/01/05 03:23:36 UTC
[GitHub] [incubator-nuttx-apps] Donny9 opened a new pull request #957: ntpc: optimize stack used
Donny9 opened a new pull request #957:
URL: https://github.com/apache/incubator-nuttx-apps/pull/957
## Summary
ntpc: optimize stack used, this pr is related to https://github.com/apache/incubator-nuttx/pull/5159.
Signed-off-by: Jiuzhu Dong <do...@xiaomi.com>
## Impact
reduce stack used
## Testing
local compile
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] masayuki2009 commented on pull request #957: ntpc: optimize stack used
Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on pull request #957:
URL: https://github.com/apache/incubator-nuttx-apps/pull/957#issuecomment-1005422859
@Donny9
I confirmed this PR with spresense:wifi.
Actually, it consumed less memory (2332 bytes) than the latest upstream (3052 bytes).
However, I think we need to modify the default NETUTILS_NTPCLIENT_STACKSIZE as well.
```
14 14 100 RR Task --- Waiting Signal 00000000 004024 002332 57.9% NTP daemon 0.pool.ntp.org;1.pool.ntp.org;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] Donny9 commented on pull request #957: ntpc: optimize stack used
Posted by GitBox <gi...@apache.org>.
Donny9 commented on pull request #957:
URL: https://github.com/apache/incubator-nuttx-apps/pull/957#issuecomment-1005433301
> @Donny9
>
> I confirmed this PR with spresense:wifi. Actually, it consumed less memory (2332 bytes) than the latest upstream (3052 bytes). However, I think we need to modify the default NETUTILS_NTPCLIENT_STACKSIZE as well.
>
> ```
> 14 14 100 RR Task --- Waiting Signal 00000000 004024 002332 57.9% NTP daemon 0.pool.ntp.org;1.pool.ntp.org;
> ```
Please wait a minute, I will continue optimize this stack used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #957: ntpc: optimize stack used
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #957:
URL: https://github.com/apache/incubator-nuttx-apps/pull/957#issuecomment-1005452735
@masayuki2009 could you try the new change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] masayuki2009 commented on pull request #957: ntpc: optimize stack used
Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on pull request #957:
URL: https://github.com/apache/incubator-nuttx-apps/pull/957#issuecomment-1005523807
@Donny9
The latest commit reduces the stack size.
Thanks for the fix.
```
14 14 100 RR Task --- Waiting Signal 00000000 001976 001740 88.0%! NTP daemon 0.pool.ntp.org;1.pool.ntp.org;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] masayuki2009 merged pull request #957: ntpc: optimize stack used
Posted by GitBox <gi...@apache.org>.
masayuki2009 merged pull request #957:
URL: https://github.com/apache/incubator-nuttx-apps/pull/957
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org