You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2022/01/16 11:18:23 UTC

[GitHub] [logging-log4cxx] ams-tschoening commented on a change in pull request #102: Create intermediate directories for both fixedwindowrollingpolicy and…

ams-tschoening commented on a change in pull request #102:
URL: https://github.com/apache/logging-log4cxx/pull/102#discussion_r785426142



##########
File path: src/main/cpp/rollingpolicybase.cpp
##########
@@ -38,6 +39,7 @@ IMPLEMENT_LOG4CXX_OBJECT(RollingPolicyBase)
 
 RollingPolicyBase::RollingPolicyBase()
 {
+	createIntermediateDirectories = false;

Review comment:
       While I understand using `false` for backwards compatibility, isn't the whole point of the [issue](https://issues.apache.org/jira/browse/LOGCXX-525) and PR to fix unexpected behavior/limitations? Other implementations of [appenders](https://logback.qos.ch/manual/appenders.html#FileAppender) for .e.g Logback seem to create those dirs by default as well:
   
   > If the parent directory of the file does not exist, FileAppender will automatically create it, including any necessary but nonexistent parent directories.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org