[jira] [Commented] (TINKERPOP-1185) Gremlin Console should only load/instantiate configured plugins

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TINKERPOP-1185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15176767#comment-15176767 ] 

ASF GitHub Bot commented on TINKERPOP-1185:
-------------------------------------------

Github user bdeggleston commented on the pull request:

    https://github.com/apache/incubator-tinkerpop/pull/245#issuecomment-191503050
  
    It would also defer any failures for `:plugin list`, yes. `:plugin install` should be ok, assuming it only attempts to load the plugin class being installed.
    
    To answer your question about preventing the failures during `:plugin list`: we should be able to catch exceptions, but we couldn't prevent any side effects (file io, etc) that occur during class initialization. That's another problem with deferring, `:plugin list` could end up having a lot of unintended side effects depending on what's on the classpath.
    
    So then I guess it boils down to whether you think it's better to auto discover plugins, or better to skip loading unused classes.


> Gremlin Console should only load/instantiate configured plugins
> ---------------------------------------------------------------
>
>                 Key: TINKERPOP-1185
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1185
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: console
>    Affects Versions: 3.1.1-incubating
>            Reporter: Blake Eggleston
>            Assignee: Blake Eggleston
>
> Currently, gremlin-console will load and instantiate any GremlinPlugins on the classpath. It should only load and instantiate the plugins configured in plugins.txt



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)