You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2012/02/15 22:15:15 UTC

svn commit: r1244734 - /commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/PatternFileSelector.java

Author: ggregory
Date: Wed Feb 15 21:15:14 2012
New Revision: 1244734

URL: http://svn.apache.org/viewvc?rev=1244734&view=rev
Log:
Fix Javadocs checkstyle issues.

Modified:
    commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/PatternFileSelector.java

Modified: commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/PatternFileSelector.java
URL: http://svn.apache.org/viewvc/commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/PatternFileSelector.java?rev=1244734&r1=1244733&r2=1244734&view=diff
==============================================================================
--- commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/PatternFileSelector.java (original)
+++ commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/PatternFileSelector.java Wed Feb 15 21:15:14 2012
@@ -22,6 +22,7 @@ import java.util.regex.Pattern;
  * A {@link FileSelector} that selects based on regular expressions matched against base filename.
  *
  * @since 2.1
+ * @author <a href="http://commons.apache.org/vfs/team-list.html">Commons VFS team</a>
  */
 public class PatternFileSelector implements FileSelector
 {

Re: svn commit: r1244734 - /commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/PatternFileSelector.java

Posted by Gary Gregory <ga...@gmail.com>.
On Thu, Feb 23, 2012 at 6:03 AM, sebb <se...@gmail.com> wrote:

> On 15 February 2012 21:15,  <gg...@apache.org> wrote:
> > Author: ggregory
> > Date: Wed Feb 15 21:15:14 2012
> > New Revision: 1244734
> >
> > URL: http://svn.apache.org/viewvc?rev=1244734&view=rev
> > Log:
> > Fix Javadocs checkstyle issues.
> >
> > Modified:
> >
>  commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/PatternFileSelector.java
> >
> > Modified:
> commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/PatternFileSelector.java
> > URL:
> http://svn.apache.org/viewvc/commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/PatternFileSelector.java?rev=1244734&r1=1244733&r2=1244734&view=diff
> >
> ==============================================================================
> > ---
> commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/PatternFileSelector.java
> (original)
> > +++
> commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/PatternFileSelector.java
> Wed Feb 15 21:15:14 2012
> > @@ -22,6 +22,7 @@ import java.util.regex.Pattern;
> >  * A {@link FileSelector} that selects based on regular expressions
> matched against base filename.
> >  *
> >  * @since 2.1
> > + * @author <a href="http://commons.apache.org/vfs/team-list.html">Commons
> VFS team</a>
>
> -1
>
> @author tags for individuals are deprecated.
> It makes it easier to check if they are absent or present, rather than
> having to check the content of the tag.
>
> If CheckStyle is set up to insist on an @author tag that is wrong; it
> should rather disallow them.
>

Fine by me, I was going by what checkstyle reported. Can you fix CS?

Gary


>
> >  */
> >  public class PatternFileSelector implements FileSelector
> >  {
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>


-- 
E-Mail: garydgregory@gmail.com | ggregory@apache.org
JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

Re: svn commit: r1244734 - /commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/PatternFileSelector.java

Posted by sebb <se...@gmail.com>.
On 15 February 2012 21:15,  <gg...@apache.org> wrote:
> Author: ggregory
> Date: Wed Feb 15 21:15:14 2012
> New Revision: 1244734
>
> URL: http://svn.apache.org/viewvc?rev=1244734&view=rev
> Log:
> Fix Javadocs checkstyle issues.
>
> Modified:
>    commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/PatternFileSelector.java
>
> Modified: commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/PatternFileSelector.java
> URL: http://svn.apache.org/viewvc/commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/PatternFileSelector.java?rev=1244734&r1=1244733&r2=1244734&view=diff
> ==============================================================================
> --- commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/PatternFileSelector.java (original)
> +++ commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/PatternFileSelector.java Wed Feb 15 21:15:14 2012
> @@ -22,6 +22,7 @@ import java.util.regex.Pattern;
>  * A {@link FileSelector} that selects based on regular expressions matched against base filename.
>  *
>  * @since 2.1
> + * @author <a href="http://commons.apache.org/vfs/team-list.html">Commons VFS team</a>

-1

@author tags for individuals are deprecated.
It makes it easier to check if they are absent or present, rather than
having to check the content of the tag.

If CheckStyle is set up to insist on an @author tag that is wrong; it
should rather disallow them.

>  */
>  public class PatternFileSelector implements FileSelector
>  {
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org