[jira] [Commented] (TS-2751) remove ProtocolNetAccept

["James Peach (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TS-2751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13980173#comment-13980173 ] 

James Peach commented on TS-2751:
---------------------------------

Once this is done, we should be able to remove {{SessionAccept::createNetAccept}}, because the corresponding {{NetProcessor}} already creates the right {{NetAccept}} subclass.

> remove ProtocolNetAccept
> ------------------------
>
>                 Key: TS-2751
>                 URL: https://issues.apache.org/jira/browse/TS-2751
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Core, SPDY
>            Reporter: James Peach
>
> We should remove {{ProtocolNetAccept}}. {{ProtocolNetAccept}} is used to issue an initial read request so that the leading bytes of the client session can be snooped to detect the protocol being issued by the client. However, I'm pretty sure that this can be implemented directly by {{ProtocolAcceptCont}} neé {{ProtocolDetectSessionAccept}} using the same technique that is used for SSL NPN and ALPN. Additionally, we should remove the probe state from {{UnixNetVConnection}}, which we can do either by adding a peek operation to {{NetVConnection}}, or continuing to use {{do_io_read}}, but retaining the buffered data and passing that on to the client session state that we subsequently spawn.



--
This message was sent by Atlassian JIRA
(v6.2#6252)