[GitHub] kristw commented on issue #5680: [SIP-5] [Embeddable Charts] Decouple charts from slice and formData

[GitBox <gi...@apache.org>]

kristw commented on issue #5680: [SIP-5] [Embeddable Charts] Decouple charts from slice and formData
URL: https://github.com/apache/incubator-superset/issues/5680#issuecomment-414829767
 
 
   Thanks @mistercrunch 
   
   > Note that the chart function's signature is actually `function (slice, payload, setControlValue)`. `setControlValue` is a hook to a Redux action that allows for the chart to modify controls. 
   
   I have revised the proposal above to include how to handle `setControlValue`. 
   
   > To make this frontend visualization plugin possible, we'll need to figure out how to get rid of the visualization-specific backend code in viz.py over time, to make sure that visualizations plugins are fully defined as Javascript. 
   
   Agree. Let me move this discussion into another SIP, so this one will be kept small and focus on the front-end chart code clean up. We aim that the first pass of this process is to decouple front-end side of these classic vis into packages and be able to use current APIs to power them (i.e. without modifying viz.py yet). Meanwhile there are other workstreams on defining the common query and data format for explore API v2 that can be used to power multiple visualizations and decide what are the post-transformations in js.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org