You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/05/14 19:50:00 UTC
[jira] [Commented] (MINIFICPP-495) bootstrap.sh will exit with
error in default install Debian systems
[ https://issues.apache.org/jira/browse/MINIFICPP-495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16474719#comment-16474719 ]
ASF GitHub Bot commented on MINIFICPP-495:
------------------------------------------
GitHub user apiri opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/330
MINIFICPP-495 Move shebang line to first in the file.
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [X] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [X] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [X] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apiri/nifi-minifi-cpp MINIFI-495
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi-minifi-cpp/pull/330.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #330
----
commit 58026f926f7f36fd90d8e2802bc2876ef6035051
Author: Aldrin Piri <al...@...>
Date: 2018-05-14T19:49:09Z
MINIFICPP-495 Move shebang line to first in the file.
----
> bootstrap.sh will exit with error in default install Debian systems
> -------------------------------------------------------------------
>
> Key: MINIFICPP-495
> URL: https://issues.apache.org/jira/browse/MINIFICPP-495
> Project: NiFi MiNiFi C++
> Issue Type: Bug
> Reporter: Aldrin Piri
> Assignee: Aldrin Piri
> Priority: Major
> Fix For: 0.5.0
>
>
> With the shebang line following comments, the default non-interactive shell will be used on the system. Because Debian systems default to dash for non-interactive shells the bootstrap will fail starting at Line 35 where bash syntax is utilized.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)