You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Vitalyi Brodetskyi <vb...@hortonworks.com> on 2016/03/04 16:44:50 UTC
Review Request 44392: Alert "Metadata Server Web UI" using hardcoded
value for port
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44392/
-----------------------------------------------------------
Review request for Ambari, Dmitro Lisnichenko, Dmytro Sen, and Jonathan Hurley.
Bugs: AMBARI-15301
https://issues.apache.org/jira/browse/AMBARI-15301
Repository: ambari
Description
-------
When using custom value for Atlas port, web ui alert fails. This alert uses herdcoded value for port.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog222.java b8d47f9
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/alerts.json 5eaaace
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog222Test.java 5445b32
Diff: https://reviews.apache.org/r/44392/diff/
Testing
-------
mvn clean test
Thanks,
Vitalyi Brodetskyi
Re: Review Request 44392: Alert "Metadata Server Web UI" using
hardcoded value for port
Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44392/#review122084
-----------------------------------------------------------
Ship it!
Ship It!
- Dmytro Sen
On Март 4, 2016, 3:44 п.п., Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44392/
> -----------------------------------------------------------
>
> (Updated Март 4, 2016, 3:44 п.п.)
>
>
> Review request for Ambari, Dmitro Lisnichenko, Dmytro Sen, and Jonathan Hurley.
>
>
> Bugs: AMBARI-15301
> https://issues.apache.org/jira/browse/AMBARI-15301
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When using custom value for Atlas port, web ui alert fails. This alert uses herdcoded value for port.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog222.java b8d47f9
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/alerts.json 5eaaace
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog222Test.java 5445b32
>
> Diff: https://reviews.apache.org/r/44392/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 44392: Alert "Metadata Server Web UI" using
hardcoded value for port
Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
> On Березень 4, 2016, 4:12 після полудня, Jonathan Hurley wrote:
> > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/alerts.json, lines 40-41
> > <https://reviews.apache.org/r/44392/diff/1/?file=1281019#file1281019line40>
> >
> > Any reason the host name was removed? It's probably fine since the alert will default to the host it's running on. Just curious.
We don't have {{hostname}} property in cluster config which we are using in alerts to get needed properties.
- Vitalyi
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44392/#review122093
-----------------------------------------------------------
On Березень 4, 2016, 3:44 після полудня, Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44392/
> -----------------------------------------------------------
>
> (Updated Березень 4, 2016, 3:44 після полудня)
>
>
> Review request for Ambari, Dmitro Lisnichenko, Dmytro Sen, and Jonathan Hurley.
>
>
> Bugs: AMBARI-15301
> https://issues.apache.org/jira/browse/AMBARI-15301
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When using custom value for Atlas port, web ui alert fails. This alert uses herdcoded value for port.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog222.java b8d47f9
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/alerts.json 5eaaace
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog222Test.java 5445b32
>
> Diff: https://reviews.apache.org/r/44392/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 44392: Alert "Metadata Server Web UI" using
hardcoded value for port
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44392/#review122093
-----------------------------------------------------------
Ship it!
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/alerts.json (lines 40 - 41)
<https://reviews.apache.org/r/44392/#comment184005>
Any reason the host name was removed? It's probably fine since the alert will default to the host it's running on. Just curious.
- Jonathan Hurley
On March 4, 2016, 10:44 a.m., Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44392/
> -----------------------------------------------------------
>
> (Updated March 4, 2016, 10:44 a.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko, Dmytro Sen, and Jonathan Hurley.
>
>
> Bugs: AMBARI-15301
> https://issues.apache.org/jira/browse/AMBARI-15301
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When using custom value for Atlas port, web ui alert fails. This alert uses herdcoded value for port.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog222.java b8d47f9
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/alerts.json 5eaaace
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog222Test.java 5445b32
>
> Diff: https://reviews.apache.org/r/44392/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>