[GitHub] dhruve commented on a change in pull request #22015: [SPARK-20286][SPARK-24786][Core][DynamicAllocation] Release executors on unpersisting RDD

[GitBox <gi...@apache.org>]

dhruve commented on a change in pull request #22015: [SPARK-20286][SPARK-24786][Core][DynamicAllocation] Release executors on unpersisting RDD
URL: https://github.com/apache/spark/pull/22015#discussion_r259599878
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/util/JsonProtocol.scala
 ##########
 @@ -645,7 +646,10 @@ private[spark] object JsonProtocol {
   }
 
   def unpersistRDDFromJson(json: JValue): SparkListenerUnpersistRDD = {
-    SparkListenerUnpersistRDD((json \ "RDD ID").extract[Int])
+    SparkListenerUnpersistRDD(
+      (json \ "RDD ID").extract[Int],
+      (json \ "Executor IDs").extract[Seq[String]]
 
 Review comment:
   It returns an empty List, so we should be able to read older event logs as well.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org