You are viewing a plain text version of this content. The canonical link for it is here.

Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2021/11/29 02:58:39 UTC

[GitHub] [hadoop] tomscut edited a comment on pull request #3676: HDFS-16331. Make dfs.blockreport.intervalMsec reconfigurable

tomscut edited a comment on pull request #3676:
URL: https://github.com/apache/hadoop/pull/3676#issuecomment-981190467


   > In the following code, `datanode.getDnConf().getBlockReportInterval()` can not get the reconfigured property. Do we need to fix it?
   > 
   > https://github.com/apache/hadoop/blob/c9d64bad37fbfbaa77481f67338b39a029d7dc51/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java#L2626
   
   Hi @tasanuma , I fixed this. PTAL. Thank you very much.
   
   In addition, I find that `case DFS_DATANODE_DATA_DIR_KEY` and `case DFS_DATANODE_BALANCE_MAX_NUM_CONCURRENT_MOVES_KEY` are indented too much (two more indented), do I need to fix them? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org