You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/12/30 09:35:59 UTC
[GitHub] [flink] docete opened a new pull request #10722: [FLINK-15421][table-planner-blink] Fix TimestampMaxAggFunction/Timest…
docete opened a new pull request #10722: [FLINK-15421][table-planner-blink] Fix TimestampMaxAggFunction/Timest…
URL: https://github.com/apache/flink/pull/10722
…ampMinAggFunction to accept SqlTimestamp values
## What is the purpose of the change
The `MaxWithRetractAggFunction`/`MinWithRetractAggFunction` in blink planner not support "accumulate(acc, Object value)" generic object with third-part data formats. We only support internal/external format in this usage. In this PR, we use SqlTimestamp(the internal format of TimestampType) in `TimestampMaxAggFunction`/`TimestampMinAggFunction` to fix the `ClassCastException`
## Brief change log
- 5a8613d use SqlTimestamp in `TimestampMaxAggFunction` and `TimestampMinAggFunction`
## Verifying this change
This change added tests
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (**yes** / no)
- If yes, how is the feature documented? (not applicable / docs / **JavaDocs** / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] JingsongLi commented on a change in pull request #10722: [FLINK-15421][table-planner-blink] Fix TimestampMaxAggFunction/Timest…
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on a change in pull request #10722: [FLINK-15421][table-planner-blink] Fix TimestampMaxAggFunction/Timest…
URL: https://github.com/apache/flink/pull/10722#discussion_r362135282
##########
File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/functions/aggfunctions/MinWithRetractAggFunction.java
##########
@@ -367,13 +368,21 @@ public void retract(MinWithRetractAccumulator<BinaryString> acc, BinaryString va
/**
* Built-in Timestamp Min with retraction aggregate function.
*/
- public static class TimestampMinWithRetractAggFunction extends MinWithRetractAggFunction<Timestamp> {
+ public static class TimestampMinWithRetractAggFunction extends MinWithRetractAggFunction<SqlTimestamp> {
private static final long serialVersionUID = -7494198823345305907L;
+ public void accumulate(MinWithRetractAccumulator<SqlTimestamp> acc, SqlTimestamp value) throws Exception {
+ super.accumulate(acc, value);
+ }
+
+ public void retract(MinWithRetractAccumulator<SqlTimestamp> acc, SqlTimestamp value) throws Exception {
+ super.retract(acc, value);
+ }
+
@Override
- protected TypeInformation<Timestamp> getValueTypeInfo() {
- return Types.SQL_TIMESTAMP;
+ protected TypeInformation<SqlTimestamp> getValueTypeInfo() {
+ return new SqlTimestampTypeInfo(3);
Review comment:
I am a little worried about timestamp with precision 9.
Can you verify it?
Maybe we should pass precision to this class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10722: [FLINK-15421][table-planner-blink] Fix TimestampMaxAggFunction/Timest…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10722: [FLINK-15421][table-planner-blink] Fix TimestampMaxAggFunction/Timest…
URL: https://github.com/apache/flink/pull/10722#issuecomment-569627241
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 5a8613dc02845de4ee4e957a34411b6e30bae0bd (Mon Dec 30 09:39:46 UTC 2019)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wuchong commented on a change in pull request #10722: [FLINK-15421][table-planner-blink] Fix TimestampMaxAggFunction/Timest…
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #10722: [FLINK-15421][table-planner-blink] Fix TimestampMaxAggFunction/Timest…
URL: https://github.com/apache/flink/pull/10722#discussion_r362136167
##########
File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/functions/aggfunctions/MinWithRetractAggFunction.java
##########
@@ -367,13 +368,21 @@ public void retract(MinWithRetractAccumulator<BinaryString> acc, BinaryString va
/**
* Built-in Timestamp Min with retraction aggregate function.
*/
- public static class TimestampMinWithRetractAggFunction extends MinWithRetractAggFunction<Timestamp> {
+ public static class TimestampMinWithRetractAggFunction extends MinWithRetractAggFunction<SqlTimestamp> {
private static final long serialVersionUID = -7494198823345305907L;
+ public void accumulate(MinWithRetractAccumulator<SqlTimestamp> acc, SqlTimestamp value) throws Exception {
+ super.accumulate(acc, value);
+ }
+
+ public void retract(MinWithRetractAccumulator<SqlTimestamp> acc, SqlTimestamp value) throws Exception {
+ super.retract(acc, value);
+ }
+
@Override
- protected TypeInformation<Timestamp> getValueTypeInfo() {
- return Types.SQL_TIMESTAMP;
+ protected TypeInformation<SqlTimestamp> getValueTypeInfo() {
+ return new SqlTimestampTypeInfo(3);
Review comment:
Good point.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10722: [FLINK-15421][table-planner-blink] Fix TimestampMaxAggFunction/Timest…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10722: [FLINK-15421][table-planner-blink] Fix TimestampMaxAggFunction/Timest…
URL: https://github.com/apache/flink/pull/10722#issuecomment-569636753
<!--
Meta data
Hash:d940052615fe001bb881b0e4ba4fb6e6423ef7ec Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:d940052615fe001bb881b0e4ba4fb6e6423ef7ec
-->
## CI report:
* d940052615fe001bb881b0e4ba4fb6e6423ef7ec UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] docete edited a comment on issue #10722: [FLINK-15421][table-planner-blink] Fix TimestampMaxAggFunction/Timest…
Posted by GitBox <gi...@apache.org>.
docete edited a comment on issue #10722: [FLINK-15421][table-planner-blink] Fix TimestampMaxAggFunction/Timest…
URL: https://github.com/apache/flink/pull/10722#issuecomment-569634718
> `SqlTimestamp` is introduced after 1.9 is released, can this pr fix 1.9?
@libenchao I will open another PR to fix this in 1.9
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10722: [FLINK-15421][table-planner-blink] Fix TimestampMaxAggFunction/Timest…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10722: [FLINK-15421][table-planner-blink] Fix TimestampMaxAggFunction/Timest…
URL: https://github.com/apache/flink/pull/10722#issuecomment-569636753
<!--
Meta data
Hash:d940052615fe001bb881b0e4ba4fb6e6423ef7ec Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3981 TriggerType:PUSH TriggerID:d940052615fe001bb881b0e4ba4fb6e6423ef7ec
Hash:d940052615fe001bb881b0e4ba4fb6e6423ef7ec Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142631823 TriggerType:PUSH TriggerID:d940052615fe001bb881b0e4ba4fb6e6423ef7ec
Hash:897dc8ace2189c22dc4dc2f312d552c83b724626 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142716227 TriggerType:PUSH TriggerID:897dc8ace2189c22dc4dc2f312d552c83b724626
Hash:897dc8ace2189c22dc4dc2f312d552c83b724626 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3996 TriggerType:PUSH TriggerID:897dc8ace2189c22dc4dc2f312d552c83b724626
-->
## CI report:
* d940052615fe001bb881b0e4ba4fb6e6423ef7ec Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142631823) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3981)
* 897dc8ace2189c22dc4dc2f312d552c83b724626 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142716227) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3996)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10722: [FLINK-15421][table-planner-blink] Fix TimestampMaxAggFunction/Timest…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10722: [FLINK-15421][table-planner-blink] Fix TimestampMaxAggFunction/Timest…
URL: https://github.com/apache/flink/pull/10722#issuecomment-569636753
<!--
Meta data
Hash:d940052615fe001bb881b0e4ba4fb6e6423ef7ec Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3981 TriggerType:PUSH TriggerID:d940052615fe001bb881b0e4ba4fb6e6423ef7ec
Hash:d940052615fe001bb881b0e4ba4fb6e6423ef7ec Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142631823 TriggerType:PUSH TriggerID:d940052615fe001bb881b0e4ba4fb6e6423ef7ec
-->
## CI report:
* d940052615fe001bb881b0e4ba4fb6e6423ef7ec Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142631823) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3981)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wuchong merged pull request #10722: [FLINK-15421][table-planner-blink] Fix TimestampMaxAggFunction/Timest…
Posted by GitBox <gi...@apache.org>.
wuchong merged pull request #10722: [FLINK-15421][table-planner-blink] Fix TimestampMaxAggFunction/Timest…
URL: https://github.com/apache/flink/pull/10722
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10722: [FLINK-15421][table-planner-blink] Fix TimestampMaxAggFunction/Timest…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10722: [FLINK-15421][table-planner-blink] Fix TimestampMaxAggFunction/Timest…
URL: https://github.com/apache/flink/pull/10722#issuecomment-569636753
<!--
Meta data
Hash:d940052615fe001bb881b0e4ba4fb6e6423ef7ec Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3981 TriggerType:PUSH TriggerID:d940052615fe001bb881b0e4ba4fb6e6423ef7ec
Hash:d940052615fe001bb881b0e4ba4fb6e6423ef7ec Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142631823 TriggerType:PUSH TriggerID:d940052615fe001bb881b0e4ba4fb6e6423ef7ec
Hash:897dc8ace2189c22dc4dc2f312d552c83b724626 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/142716227 TriggerType:PUSH TriggerID:897dc8ace2189c22dc4dc2f312d552c83b724626
Hash:897dc8ace2189c22dc4dc2f312d552c83b724626 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3996 TriggerType:PUSH TriggerID:897dc8ace2189c22dc4dc2f312d552c83b724626
-->
## CI report:
* d940052615fe001bb881b0e4ba4fb6e6423ef7ec Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142631823) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3981)
* 897dc8ace2189c22dc4dc2f312d552c83b724626 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/142716227) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3996)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] docete commented on a change in pull request #10722: [FLINK-15421][table-planner-blink] Fix TimestampMaxAggFunction/Timest…
Posted by GitBox <gi...@apache.org>.
docete commented on a change in pull request #10722: [FLINK-15421][table-planner-blink] Fix TimestampMaxAggFunction/Timest…
URL: https://github.com/apache/flink/pull/10722#discussion_r362136378
##########
File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/functions/aggfunctions/MinWithRetractAggFunction.java
##########
@@ -367,13 +368,21 @@ public void retract(MinWithRetractAccumulator<BinaryString> acc, BinaryString va
/**
* Built-in Timestamp Min with retraction aggregate function.
*/
- public static class TimestampMinWithRetractAggFunction extends MinWithRetractAggFunction<Timestamp> {
+ public static class TimestampMinWithRetractAggFunction extends MinWithRetractAggFunction<SqlTimestamp> {
private static final long serialVersionUID = -7494198823345305907L;
+ public void accumulate(MinWithRetractAccumulator<SqlTimestamp> acc, SqlTimestamp value) throws Exception {
+ super.accumulate(acc, value);
+ }
+
+ public void retract(MinWithRetractAccumulator<SqlTimestamp> acc, SqlTimestamp value) throws Exception {
+ super.retract(acc, value);
+ }
+
@Override
- protected TypeInformation<Timestamp> getValueTypeInfo() {
- return Types.SQL_TIMESTAMP;
+ protected TypeInformation<SqlTimestamp> getValueTypeInfo() {
+ return new SqlTimestampTypeInfo(3);
Review comment:
Actually the TimestampMaxWithRetractAggFunction/TimestampMinWithRetractAggFunction are not support high precision(larger than 3) now. We check this in `AggFunctionFactory`.
But let them support high precision in this PR is OK to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] libenchao commented on issue #10722: [FLINK-15421][table-planner-blink] Fix TimestampMaxAggFunction/Timest…
Posted by GitBox <gi...@apache.org>.
libenchao commented on issue #10722: [FLINK-15421][table-planner-blink] Fix TimestampMaxAggFunction/Timest…
URL: https://github.com/apache/flink/pull/10722#issuecomment-569631578
@docete Thanks for the fix.
`SqlTimestamp` is introduced after 1.9 is released, can this pr fix 1.9?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10722: [FLINK-15421][table-planner-blink] Fix TimestampMaxAggFunction/Timest…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10722: [FLINK-15421][table-planner-blink] Fix TimestampMaxAggFunction/Timest…
URL: https://github.com/apache/flink/pull/10722#issuecomment-569636753
<!--
Meta data
Hash:d940052615fe001bb881b0e4ba4fb6e6423ef7ec Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3981 TriggerType:PUSH TriggerID:d940052615fe001bb881b0e4ba4fb6e6423ef7ec
Hash:d940052615fe001bb881b0e4ba4fb6e6423ef7ec Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142631823 TriggerType:PUSH TriggerID:d940052615fe001bb881b0e4ba4fb6e6423ef7ec
Hash:897dc8ace2189c22dc4dc2f312d552c83b724626 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142716227 TriggerType:PUSH TriggerID:897dc8ace2189c22dc4dc2f312d552c83b724626
Hash:897dc8ace2189c22dc4dc2f312d552c83b724626 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3996 TriggerType:PUSH TriggerID:897dc8ace2189c22dc4dc2f312d552c83b724626
-->
## CI report:
* d940052615fe001bb881b0e4ba4fb6e6423ef7ec Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142631823) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3981)
* 897dc8ace2189c22dc4dc2f312d552c83b724626 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142716227) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3996)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10722: [FLINK-15421][table-planner-blink] Fix TimestampMaxAggFunction/Timest…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10722: [FLINK-15421][table-planner-blink] Fix TimestampMaxAggFunction/Timest…
URL: https://github.com/apache/flink/pull/10722#issuecomment-569636753
<!--
Meta data
Hash:d940052615fe001bb881b0e4ba4fb6e6423ef7ec Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3981 TriggerType:PUSH TriggerID:d940052615fe001bb881b0e4ba4fb6e6423ef7ec
Hash:d940052615fe001bb881b0e4ba4fb6e6423ef7ec Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142631823 TriggerType:PUSH TriggerID:d940052615fe001bb881b0e4ba4fb6e6423ef7ec
Hash:897dc8ace2189c22dc4dc2f312d552c83b724626 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:897dc8ace2189c22dc4dc2f312d552c83b724626
-->
## CI report:
* d940052615fe001bb881b0e4ba4fb6e6423ef7ec Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142631823) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3981)
* 897dc8ace2189c22dc4dc2f312d552c83b724626 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10722: [FLINK-15421][table-planner-blink] Fix TimestampMaxAggFunction/Timest…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10722: [FLINK-15421][table-planner-blink] Fix TimestampMaxAggFunction/Timest…
URL: https://github.com/apache/flink/pull/10722#issuecomment-569636753
<!--
Meta data
Hash:d940052615fe001bb881b0e4ba4fb6e6423ef7ec Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3981 TriggerType:PUSH TriggerID:d940052615fe001bb881b0e4ba4fb6e6423ef7ec
Hash:d940052615fe001bb881b0e4ba4fb6e6423ef7ec Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/142631823 TriggerType:PUSH TriggerID:d940052615fe001bb881b0e4ba4fb6e6423ef7ec
-->
## CI report:
* d940052615fe001bb881b0e4ba4fb6e6423ef7ec Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/142631823) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3981)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] docete commented on issue #10722: [FLINK-15421][table-planner-blink] Fix TimestampMaxAggFunction/Timest…
Posted by GitBox <gi...@apache.org>.
docete commented on issue #10722: [FLINK-15421][table-planner-blink] Fix TimestampMaxAggFunction/Timest…
URL: https://github.com/apache/flink/pull/10722#issuecomment-569634718
> `SqlTimestamp` is introduced after 1.9 is released, can this pr fix 1.9?
@libenchao I will open another PR to fix this in 1.9
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services