You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by ijokarumawak <gi...@git.apache.org> on 2017/07/06 12:03:22 UTC
[GitHub] nifi pull request #1984: NIFI-4155: Expand EnforceOrder capability to cluste...
GitHub user ijokarumawak opened a pull request:
https://github.com/apache/nifi/pull/1984
NIFI-4155: Expand EnforceOrder capability to cluster
- Added 'Ordering Scope' to specify how it should manage state, to choose from local and cluster.
- Avoid unnecessary status update if it does not make any progress, only update it when order proceeds.
- If updating state fails, due to it is already updated by other nodes, rollback the session to process the same FlowFiles again.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [x] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ijokarumawak/nifi nifi-4155
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1984.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1984
----
commit 11fa5ff13b5fcc5b8f5b1de577b8a061cc4ca174
Author: Koji Kawamura <ij...@apache.org>
Date: 2017-07-06T11:53:23Z
NIFI-4155: Expand EnforceOrder capability to cluster
- Added 'Ordering Scope' to specify how it should manage state, to choose from local and cluster.
- Avoid unnecessary status update if it does not make any progress, only update it when order proceeds.
- If updating state fails, due to it is already updated by other nodes, rollback the session to process the same FlowFiles again.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1984: NIFI-4155: Expand EnforceOrder capability to cluste...
Posted by ijokarumawak <gi...@git.apache.org>.
Github user ijokarumawak closed the pull request at:
https://github.com/apache/nifi/pull/1984
---
[GitHub] nifi issue #1984: NIFI-4155: Expand EnforceOrder capability to cluster
Posted by mattyb149 <gi...@git.apache.org>.
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/1984
@ijokarumawak Is this one ready to go, or needs more doc, etc.?
---
[GitHub] nifi issue #1984: NIFI-4155: Expand EnforceOrder capability to cluster
Posted by JPercivall <gi...@git.apache.org>.
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/1984
@ijokarumawak while we are still using ZooKeeper as the only cluster state provider and using it for the cluster coordinator, are we sure we want to add this option? This goes hand-in-hand with the work to add state to UpdateAttribute, specifically this comment[1].
@markap14 do you have opinions on this?
[1] https://issues.apache.org/jira/browse/NIFI-1582
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1984: NIFI-4155: Expand EnforceOrder capability to cluster
Posted by ijokarumawak <gi...@git.apache.org>.
Github user ijokarumawak commented on the issue:
https://github.com/apache/nifi/pull/1984
@mattyb149 Thanks for checking this. I reconsider the motivation and this PR's approach and found that it can be supported by NIFI-5516 differently and more nicely. Closing this PR. Please see this comment for details https://issues.apache.org/jira/browse/NIFI-4155?focusedCommentId=16585635&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16585635
---
[GitHub] nifi issue #1984: NIFI-4155: Expand EnforceOrder capability to cluster
Posted by ijokarumawak <gi...@git.apache.org>.
Github user ijokarumawak commented on the issue:
https://github.com/apache/nifi/pull/1984
@JPercivall Thanks for your comment. Yes, I concerned about it may hammer Zk, too. But now we have [Redis backed state manager](https://github.com/apache/nifi/tree/master/nifi-nar-bundles/nifi-redis-bundle/nifi-redis-extensions/src/main/java/org/apache/nifi/redis/state) too. That can perform well compared to Zk. Also I wrote [doc for Cluster scope](https://github.com/apache/nifi/pull/1984/files#diff-64bdb3d4f3927cdfb538dd95975af65aR189) to use it only if necessary, it wouldn't be enough, though..
I think 'being able to do something if they know what they're doing' is better than not providing that option.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1984: NIFI-4155: Expand EnforceOrder capability to cluster
Posted by JPercivall <gi...@git.apache.org>.
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/1984
@ijokarumawak ah I remember seeing that come up but didn't realize it was finished. That's awesome!
Definitely agree with your second statement but I'd add that we should warn the users of the danger in the description of the cluster state option here and potentially add it to the processor capability description too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---