[GitHub] [drill] aravi5 commented on a change in pull request #1760: DRILL-7164: KafkaFilterPushdownTest is sometimes failing to pattern m…

[GitBox <gi...@apache.org>]

aravi5 commented on a change in pull request #1760: DRILL-7164: KafkaFilterPushdownTest is sometimes failing to pattern m…
URL: https://github.com/apache/drill/pull/1760#discussion_r277177508
 
 

 ##########
 File path: exec/java-exec/src/test/java/org/apache/drill/PlanTestBase.java
 ##########
 @@ -92,7 +91,20 @@ public static void testPlanMatchingPatterns(String query, String[] expectedPatte
 
   public static void testPlanMatchingPatterns(String query, Pattern[] expectedPatterns, Pattern[] excludedPatterns)
     throws Exception {
-    final String plan = getPlanInString("EXPLAIN PLAN for " + QueryTestUtil.normalizeQuery(query), OPTIQ_FORMAT);
+    testPlanMatchingPatterns(query, OPTIQ_FORMAT, expectedPatterns, excludedPatterns);
+  }
+
+  public static void testPlanMatchingPatterns(String query, String planFormat,
 
 Review comment:
   Minor comment  here. `planFormat` was not exposed to tests earlier. Should we restrict the format to `OPTIQ_FORMAT` and `JSON_FORMAT`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services