You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by al...@apache.org on 2017/09/15 10:51:56 UTC

mesos git commit: Added workaround for a docker bug in docker build helper.

Repository: mesos
Updated Branches:
  refs/heads/master e42d626ab -> bfadcdebc


Added workaround for a docker bug in docker build helper.

This patch adds workaround for an incorrect docker file execution on
Apache CI due to a docker bug, see:
https://github.com/moby/moby/issues/9547

Quote from the docker issue:
The execution of `chmod +x b.sh` just prior to trying to running b.sh
is leaving it in the 'Text file busy' state for long enough that then
running it fails.

Review: https://reviews.apache.org/r/62246/


Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/bfadcdeb
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/bfadcdeb
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/bfadcdeb

Branch: refs/heads/master
Commit: bfadcdebc32c63388fd373c280b1cf02498d34e0
Parents: e42d626
Author: Andrei Budnik <ab...@mesosphere.com>
Authored: Fri Sep 15 12:46:43 2017 +0200
Committer: Alexander Rukletsov <al...@apache.org>
Committed: Fri Sep 15 12:51:35 2017 +0200

----------------------------------------------------------------------
 support/docker-build.sh | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/mesos/blob/bfadcdeb/support/docker-build.sh
----------------------------------------------------------------------
diff --git a/support/docker-build.sh b/support/docker-build.sh
index 6443e56..50e693c 100755
--- a/support/docker-build.sh
+++ b/support/docker-build.sh
@@ -76,8 +76,14 @@ case $OS in
 esac
 
 # Install a more recent version of CMake than can be installed via packages.
+#
+# NOTE: We call `sync` before launching the script to workaround the docker bug.
+# See https://github.com/moby/moby/issues/9547
+#
+# TODO(abudnik): Skip this step, when a newer version of CMake package is
+# available in OS repository.
 append_dockerfile "RUN curl -sSL https://cmake.org/files/v3.8/cmake-3.8.2-Linux-x86_64.sh -o /tmp/install-cmake.sh"
-append_dockerfile "RUN chmod u+x /tmp/install-cmake.sh && /tmp/install-cmake.sh --skip-license --prefix=/usr/local"
+append_dockerfile "RUN chmod u+x /tmp/install-cmake.sh && sync && /tmp/install-cmake.sh --skip-license --prefix=/usr/local"
 
 case $COMPILER in
   gcc)