You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "Yicong-Huang (via GitHub)" <gi...@apache.org> on 2026/07/04 23:43:41 UTC
[PR] fix(ci): backport every labeled PR in a multi-commit push, not just the head [texera]
Yicong-Huang opened a new pull request, #6120:
URL: https://github.com/apache/texera/pull/6120
### What changes were proposed in this PR?
`direct-backport-push.yml` resolved exactly one PR per push event — from `head_commit.message`, falling back to `commits/{context.sha}/pulls`. When several auto-merges land on `main` in a single ref update, only the head commit was examined and the `release/*` labels on every other PR in the same push were silently dropped: no run, no commit status, no failure comment. An audit of 2026-06-01 → 2026-07-04 found 2 of 43 labeled PRs lost this way (#5802, coalesced behind #5812; and #6111, coalesced behind #6112).
Changes to the `discover` job:
- Enumerate **all** commits in the push via `compareCommits(payload.before...context.sha)` (oldest first), falling back to the head commit if the compare fails or `before` is unavailable.
- Resolve a PR per commit (same two strategies as before: `(#N)` title suffix, then `commits/{sha}/pulls` with backoff) and collect green `release/*` targets per PR.
- Output one matrix entry per `(pr_number, merge_sha, target)` pair instead of a single PR + target list.
Changes to the `push-backports` job:
- Matrix is now `include: <entries>` with `max-parallel: 1`, so cherry-picks apply in commit order and two legs never race pushes to the same release branch.
- `MERGE_SHA`/`PR_NUMBER` come from the matrix entry instead of `github.sha`/a single discover output; the cherry-pick, commit statuses, and PR comments all annotate the right commit and PR.
- Job legs are named `backport #<pr> to <target>`; the failure-annotation job-URL matcher was updated accordingly.
### Any related issues, documentation, discussions?
Closes #6119
### How was this PR tested?
- YAML parses (PyYAML) and all three embedded `github-script` blocks pass `node --check`.
- Dry-ran the new discover logic (read-only API calls) against the two historical coalesced pushes: the 2026-07-04 push (`5c4a963f7...9cd8acfbb`) yields entries for **both** #6111 and #6112 with green targets, and the 2026-06-20 push range yields #5802 while correctly skipping the unlabeled #5809/#5811/#5812. The old logic produced only the head PR in each case.
- Note: this fix is not retroactive — #5802 and #6111 still need manual backporting to `release/v1.2`.
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Fable 5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(ci): backport every labeled PR in a multi-commit push, not just the head [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #6120:
URL: https://github.com/apache/texera/pull/6120#issuecomment-4884177402
<!-- texera-benchmarks-comment -->
## ⚠️ Benchmark changes need a look
🟢 0 better · 🔴 5 worse · ⚪ 10 noise (<±5%) · 0 without baseline
> Compared against main `908a61f` benchmarked on **this same runner**, so the delta is largely free of cross-runner hardware noise. The "7d avg" column still reflects the gh-pages dashboard. Treat <±5% as noise unless repeated.
[Dashboard](https://apache.github.io/texera/dev/bench/) · [Run](https://github.com/apache/texera/actions/runs/28723399869)
| | config | throughput | MB/s | latency | max Δ latest / 7d |
|---|---|---:|---:|---:|---:|
| 🔴 | bs=10 sw=10 sl=64 | 389 | 0.238 | 24,994/34,400/34,400 us | 🔴 +8.6% / 🔴 +127.2% |
| 🔴 | bs=100 sw=10 sl=64 | 807 | 0.492 | 123,371/152,583/152,583 us | 🔴 +8.7% / 🔴 +41.4% |
| ⚪ | bs=1000 sw=10 sl=64 | 927 | 0.566 | 1,076,850/1,148,561/1,148,561 us | ⚪ within ±5% / 🔴 +11.7% |
<details><summary>Baseline details</summary>
Latest main `908a61f` from same runner
| config | metric | PR | latest main | 7d avg | Δ latest | Δ 7d |
|---|---|---:|---:|---:|---:|---:|
| bs=10 sw=10 sl=64 | throughput | 389 tuples/sec | 423 tuples/sec | 776.36 tuples/sec | -8.0% | -49.9% |
| bs=10 sw=10 sl=64 | MB/s | 0.238 MB/s | 0.258 MB/s | 0.474 MB/s | -7.8% | -49.8% |
| bs=10 sw=10 sl=64 | p50 | 24,994 us | 23,017 us | 12,636 us | +8.6% | +97.8% |
| bs=10 sw=10 sl=64 | p95 | 34,400 us | 34,371 us | 15,143 us | +0.1% | +127.2% |
| bs=10 sw=10 sl=64 | p99 | 34,400 us | 34,371 us | 18,954 us | +0.1% | +81.5% |
| bs=100 sw=10 sl=64 | throughput | 807 tuples/sec | 824 tuples/sec | 985.33 tuples/sec | -2.1% | -18.1% |
| bs=100 sw=10 sl=64 | MB/s | 0.492 MB/s | 0.503 MB/s | 0.601 MB/s | -2.2% | -18.2% |
| bs=100 sw=10 sl=64 | p50 | 123,371 us | 119,429 us | 101,671 us | +3.3% | +21.3% |
| bs=100 sw=10 sl=64 | p95 | 152,583 us | 140,373 us | 107,939 us | +8.7% | +41.4% |
| bs=100 sw=10 sl=64 | p99 | 152,583 us | 140,373 us | 113,798 us | +8.7% | +34.1% |
| bs=1000 sw=10 sl=64 | throughput | 927 tuples/sec | 922 tuples/sec | 1,016 tuples/sec | +0.5% | -8.8% |
| bs=1000 sw=10 sl=64 | MB/s | 0.566 MB/s | 0.563 MB/s | 0.62 MB/s | +0.5% | -8.8% |
| bs=1000 sw=10 sl=64 | p50 | 1,076,850 us | 1,081,936 us | 989,693 us | -0.5% | +8.8% |
| bs=1000 sw=10 sl=64 | p95 | 1,148,561 us | 1,144,141 us | 1,028,327 us | +0.4% | +11.7% |
| bs=1000 sw=10 sl=64 | p99 | 1,148,561 us | 1,144,141 us | 1,059,969 us | +0.4% | +8.4% |
</details>
<details><summary>Raw CSV</summary>
```csv
config_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
0,10,10,64,20,513.93,200,128000,389,0.238,24993.53,34400.29,34400.29
1,100,10,64,20,2479.12,2000,1280000,807,0.492,123371.13,152582.92,152582.92
2,1000,10,64,20,21563.51,20000,12800000,927,0.566,1076849.89,1148560.70,1148560.70
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(ci): backport every labeled PR in a multi-commit push, not just the head [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #6120:
URL: https://github.com/apache/texera/pull/6120#issuecomment-4884166117
<!-- texera-reviewer-suggestion -->
### Automated Reviewer Suggestions
Based on the `git blame` history of the changed files, we recommend the following reviewers:
- No candidates found from `git blame` history.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(ci): backport every labeled PR in a multi-commit push, not just the head [texera]
Posted by "Yicong-Huang (via GitHub)" <gi...@apache.org>.
Yicong-Huang merged PR #6120:
URL: https://github.com/apache/texera/pull/6120
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(ci): backport every labeled PR in a multi-commit push, not just the head [texera]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #6120:
URL: https://github.com/apache/texera/pull/6120#issuecomment-4884167471
## [Codecov](https://app.codecov.io/gh/apache/texera/pull/6120?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 59.12%. Comparing base ([`908a61f`](https://app.codecov.io/gh/apache/texera/commit/908a61f08ae521c461ca6c1b7095fc4b99140219?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`55c8068`](https://app.codecov.io/gh/apache/texera/commit/55c8068b7c22a4991a91bd34dd0145be9db2e7de?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #6120 +/- ##
=========================================
Coverage 59.12% 59.12%
Complexity 3197 3197
=========================================
Files 1132 1132
Lines 43681 43681
Branches 4734 4734
=========================================
Hits 25828 25828
Misses 16419 16419
Partials 1434 1434
```
| [Flag](https://app.codecov.io/gh/apache/texera/pull/6120/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | *Carryforward flag |
|---|---|---|---|
| [access-control-service](https://app.codecov.io/gh/apache/texera/pull/6120/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `70.00% <ø> (ø)` | | Carriedforward from [908a61f](https://app.codecov.io/gh/apache/texera/commit/908a61f08ae521c461ca6c1b7095fc4b99140219?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [agent-service](https://app.codecov.io/gh/apache/texera/pull/6120/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.59% <ø> (ø)` | | |
| [amber](https://app.codecov.io/gh/apache/texera/pull/6120/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `63.08% <ø> (ø)` | | Carriedforward from [908a61f](https://app.codecov.io/gh/apache/texera/commit/908a61f08ae521c461ca6c1b7095fc4b99140219?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [computing-unit-managing-service](https://app.codecov.io/gh/apache/texera/pull/6120/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <ø> (ø)` | | Carriedforward from [908a61f](https://app.codecov.io/gh/apache/texera/commit/908a61f08ae521c461ca6c1b7095fc4b99140219?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [config-service](https://app.codecov.io/gh/apache/texera/pull/6120/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `52.30% <ø> (ø)` | | Carriedforward from [908a61f](https://app.codecov.io/gh/apache/texera/commit/908a61f08ae521c461ca6c1b7095fc4b99140219?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [file-service](https://app.codecov.io/gh/apache/texera/pull/6120/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `62.81% <ø> (ø)` | | Carriedforward from [908a61f](https://app.codecov.io/gh/apache/texera/commit/908a61f08ae521c461ca6c1b7095fc4b99140219?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [frontend](https://app.codecov.io/gh/apache/texera/pull/6120/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `51.37% <ø> (ø)` | | Carriedforward from [908a61f](https://app.codecov.io/gh/apache/texera/commit/908a61f08ae521c461ca6c1b7095fc4b99140219?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [notebook-migration-service](https://app.codecov.io/gh/apache/texera/pull/6120/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `78.57% <ø> (ø)` | | Carriedforward from [908a61f](https://app.codecov.io/gh/apache/texera/commit/908a61f08ae521c461ca6c1b7095fc4b99140219?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [pyamber](https://app.codecov.io/gh/apache/texera/pull/6120/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `91.19% <ø> (ø)` | | Carriedforward from [908a61f](https://app.codecov.io/gh/apache/texera/commit/908a61f08ae521c461ca6c1b7095fc4b99140219?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [workflow-compiling-service](https://app.codecov.io/gh/apache/texera/pull/6120/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `55.14% <ø> (ø)` | | Carriedforward from [908a61f](https://app.codecov.io/gh/apache/texera/commit/908a61f08ae521c461ca6c1b7095fc4b99140219?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
*This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/texera/pull/6120?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org