[GitHub] [calcite] julianhyde commented on a diff in pull request #3199: [CALCITE-5698] EXTRACT from INTERVAL partially does not follow the SQL standard

["julianhyde (via GitHub)" <gi...@apache.org>]

julianhyde commented on code in PR #3199:
URL: https://github.com/apache/calcite/pull/3199#discussion_r1195676388


##########
core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java:
##########
@@ -2890,12 +2891,13 @@ private static class ExtractImplementor extends AbstractRexCallImplementor {
     }
   }
 
-  private static Expression mod(Expression operand, long factor) {
+  private static Expression mod(Expression operand, long factor, boolean floorMod) {
     if (factor == 1L) {
       return operand;
     } else {
-      return Expressions.call(BuiltInMethod.FLOOR_MOD.method,

Review Comment:
   convert '?' to 'else if' to be consistent with existing method
   
   also revert your change removing the line-break; short lines are better



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org