You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by hu...@apache.org on 2020/12/18 20:24:13 UTC

[incubator-superset] branch hugh/ch229-forward created (now e1f8e97)

This is an automated email from the ASF dual-hosted git repository.

hugh pushed a change to branch hugh/ch229-forward
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git.


      at e1f8e97  save quite

This branch includes the following new commits:

     new e1f8e97  save quite

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.



[incubator-superset] 01/01: save quite

Posted by hu...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

hugh pushed a commit to branch hugh/ch229-forward
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git

commit e1f8e973cac42b8fbca1aa41d571e131e307b2a4
Author: hughhhh <hu...@gmail.com>
AuthorDate: Fri Dec 18 15:23:24 2020 -0500

    save quite
---
 superset-frontend/src/SqlLab/components/SqlEditor.jsx | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/superset-frontend/src/SqlLab/components/SqlEditor.jsx b/superset-frontend/src/SqlLab/components/SqlEditor.jsx
index 3574d6a..2b03679 100644
--- a/superset-frontend/src/SqlLab/components/SqlEditor.jsx
+++ b/superset-frontend/src/SqlLab/components/SqlEditor.jsx
@@ -719,18 +719,24 @@ class SqlEditor extends React.PureComponent {
         <StyledModal
           visible={this.state.showCreateAsModal}
           title={t('Create View As')}
+          onHide={() => {
+            this.setState({ showCreateAsModal: false });
+          }}
           footer={<>
               <Button
                 onClick={() => this.setState({ showCreateAsModal: false })}
               >
                 Cancel
               </Button>
-            <Button buttonStyle="primary">Create</Button>
+              <Button buttonStyle="primary">Create</Button>
             </>
           }
         >
           <span>Name</span>
-          <Input placeholder="Specify name to Create View AS schema in: public"/>
+          <Input
+            placeholder="Specify name to Create View AS schema in: public"
+            onChange={this.ctasChanged.bind(this)}
+          />
         </StyledModal>
       </div>
     );