[GitHub] [incubator-opendal] Xuanwo commented on a diff in pull request #2599: github Action that needs secrets should not run on forks

["Xuanwo (via GitHub)" <gi...@apache.org>]

Xuanwo commented on code in PR #2599:
URL: https://github.com/apache/incubator-opendal/pull/2599#discussion_r1252762221


##########
.github/workflows/main.yml:
##########
@@ -0,0 +1,72 @@
+name: Controller Action

Review Comment:
   Thanks for the PR. But I don't want to change our workflows in this way.
   
   We can update our conditions from:
   
   ```yaml
   github.event_name == 'push' || !github.event.pull_request.head.repo.fork
   ``` 
   
   to 
   
   ```yaml
   (github.event_name == 'push' && github.repository == 'apache/incubator-opendal' ) || !github.event.pull_request.head.repo.fork
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org