You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by tbouron <gi...@git.apache.org> on 2018/07/26 11:03:21 UTC
[GitHub] brooklyn-docs pull request #263: Update docs to match the new Brooklyn UI
GitHub user tbouron opened a pull request:
https://github.com/apache/brooklyn-docs/pull/263
Update docs to match the new Brooklyn UI
This is the required changes to match the newly donated Brooklyn UI (see https://lists.apache.org/thread.html/20d82876f7e84244c2c4d3464a1531a10af50ca3d20e9e1de97a5faf@%3Cdev.brooklyn.apache.org%3E)
It updated the relevant portions of text as well as all the screenshot.
Note that another PR will be required for the website part, I'll push that as soon as possible
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tbouron/brooklyn-docs update/brooklyn-ui
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-docs/pull/263.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #263
----
commit 721b55b67c138e63dc6cc7e013603373483dc9c8
Author: Thomas Bouron <th...@...>
Date: 2018-07-20T12:43:30Z
Update docs to match the new Brooklyn UI
----
---
[GitHub] brooklyn-docs issue #263: Update docs to match the new Brooklyn UI
Posted by tbouron <gi...@git.apache.org>.
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-docs/pull/263
@ahgittin Added back the web console issues page + updated the IDE setup
---
[GitHub] brooklyn-docs pull request #263: Update docs to match the new Brooklyn UI
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/brooklyn-docs/pull/263
---
[GitHub] brooklyn-docs issue #263: Update docs to match the new Brooklyn UI
Posted by tbouron <gi...@git.apache.org>.
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-docs/pull/263
> Fabulously thorough job.
Thanks!
> I think guide/ops/troubleshooting/web-console-issues.md is still relevant, so we shouldn't delete that page, should we? (Also, if we do delete it, shouldn't there be a reference to that page which is deleted -- I didn't see that, and note guide/SUMMARY.md still refers to it.)
Well, we never saw this issue with the new UI hence why I deleted the page. I don't think this is relevant anymore. But thanks for the nudge about `SUMMARY.md`, I forgot to check the references, will remove.
> There is also a reference to BrooklynJavascriptGuiLauncher on ./dev/env/ide/index.md. As per comment apache/brooklyn-server#974 (comment) this is no longer supported and we should identify the best way in each IDE to run with the UI.
Didn't remove the reference as I don't think it should be part of this set of PRs (commented this on the relevant PR) But yeah, this can be updated in a following PR.
---
[GitHub] brooklyn-docs issue #263: Update docs to match the new Brooklyn UI
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the issue:
https://github.com/apache/brooklyn-docs/pull/263
Fabulously thorough job.
I think `guide/ops/troubleshooting/web-console-issues.md` is still relevant, so we shouldn't delete that page, should we? (Also, if we _do_ delete it, shouldn't there be a reference to that page which is deleted -- I didn't see that, and note `guide/SUMMARY.md` still refers to it.)
There is also a reference to `BrooklynJavascriptGuiLauncher` on `./dev/env/ide/index.md`. As per comment https://github.com/apache/brooklyn-server/pull/974#issuecomment-408083341 this is no longer supported and we should identify the best way in each IDE to run with the UI.
However that can be deferred, and the docs at this stage in this section could simply link to a REST CLI launcher class and note that we would welcome suggestions on the best way to run with osgi and the UI from within IDEs. Or if you know how to do OSGi+UI launches, add those notes, but do keep the instructions that Brooklyn+REST can be launched non-OSGi, maybe noting that some features around bundle management will be unavailable.
---