[GitHub] [arrow-rs] alamb commented on a diff in pull request #4313: Use `page_size` consistently, deprecate `pagesize`

["alamb (via GitHub)" <gi...@apache.org>]

alamb commented on code in PR #4313:
URL: https://github.com/apache/arrow-rs/pull/4313#discussion_r1210708239


##########
parquet/src/file/properties.rs:
##########
@@ -152,15 +152,33 @@ impl WriterProperties {
     /// Returns data page size limit.
     ///
     /// Note: this is a best effort limit based on the write batch size
+    #[deprecated(since = "41.0.0", note = "Use data_page_size_limit")]
     pub fn data_pagesize_limit(&self) -> usize {

Review Comment:
   What was especially annoying was the difference between `data_page_row_count_limit` and `datapage_size_limit` on the same properties module



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org