You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@arrow.apache.org by "Jörn Horstmann (Jira)" <ji...@apache.org> on 2021/01/01 10:12:00 UTC

[jira] [Commented] (ARROW-11051) [Rust] Array sum result is wrong with remainder fields when simd is on

    [ https://issues.apache.org/jira/browse/ARROW-11051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17257165#comment-17257165 ] 

Jörn Horstmann commented on ARROW-11051:
----------------------------------------

Hi [~niuzr], could you try the same with the latest master branch? There were some changes and also a bugfix how the vector masking is calculated after the 2.0 release in ARROW-10216.

> [Rust] Array sum result is wrong with remainder fields when simd is on
> ----------------------------------------------------------------------
>
>                 Key: ARROW-11051
>                 URL: https://issues.apache.org/jira/browse/ARROW-11051
>             Project: Apache Arrow
>          Issue Type: Bug
>          Components: Rust
>    Affects Versions: 2.0.0
>         Environment: Ubuntu 20.04. rustc nightly
>            Reporter: Ziru Niu
>            Priority: Major
>
> Minimal example
>  
> {quote}use arrow::\{array::PrimitiveArray, datatypes::Int64Type};
> fn main() \{
>      let mut s = vec![];
>      for _ in 0..32  
>       
>      \{
>          s.push(Some(1i64));         s.push(None);     
>      }
>      let v: PrimitiveArray<Int64Type> = s.into();
>      dbg!(arrow::compute::sum(&v));
>  }
>   
> {quote}
>  dependency
> {quote}arrow = \{version = "2", features = ["simd"]}
> {quote}
> The following code in `compute::sum` is wrong. The bit mask is checked reversed.
> {quote}            remainder.iter().enumerate().for_each(|(i, value)| \{
>                  if remainder_bits & (1 << i) != 0  \{
>                     remainder_sum = remainder_sum + *value;
>                  }
>             });
>   
> {quote}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)