You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jason Brown (JIRA)" <ji...@apache.org> on 2018/03/29 05:51:00 UTC

[jira] [Comment Edited] (CASSANDRA-7839) Support standard EC2 naming conventions in Ec2Snitch

    [ https://issues.apache.org/jira/browse/CASSANDRA-7839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16418478#comment-16418478 ] 

Jason Brown edited comment on CASSANDRA-7839 at 3/29/18 5:50 AM:
-----------------------------------------------------------------

Rebased and updated a few things based on a self-review (six months later ...). Mostly added tests and comments (and fixed a bug).

Also, I rediscovered a small feature that I added > 5 years ago: CASSANDRA-5155. That threw a small wrench into the logic here, but I've accounted for it and documented it, as well.

 
||7839||
|[branch|https://github.com/jasobrown/cassandra/tree/7839]|
|[utests & dtests|https://circleci.com/gh/jasobrown/workflows/cassandra/tree/7839]|

[~jolynch] Do you mind taking a stab at reviewing? Additionally, if [~pauloricardomg] is around and has time, I'd appreciate any feedback you have, as well.


was (Author: jasobrown):
Rebased and updated a few things based on a self-review (six months later ...). Mostly added tests and comments (and fixed a bug).

||7839||
|[branch|https://github.com/jasobrown/cassandra/tree/7839]|
|[utests &amp; dtests|https://circleci.com/gh/jasobrown/workflows/cassandra/tree/7839]|
||

[~jolynch] Do you mind taking a stab at reviewing? Additionally, if [~pauloricardomg] is around and has time, I'd appreciate any feedback you have, as well.


> Support standard EC2 naming conventions in Ec2Snitch
> ----------------------------------------------------
>
>                 Key: CASSANDRA-7839
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-7839
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Gregory Ramsperger
>            Assignee: Gregory Ramsperger
>            Priority: Major
>              Labels: docs-impacting
>         Attachments: CASSANDRA-7839-aws-naming-conventions.patch
>
>
> The EC2 snitches use datacenter and rack naming conventions inconsistent with those presented in Amazon EC2 APIs as region and availability zone. A discussion of this is found in CASSANDRA-4026. This has not been changed for valid backwards compatibility reasons. Using SnitchProperties, it is possible to switch between the legacy naming and the full, AWS-style naming. 
> Proposal:
> * introduce a property (ec2_naming_scheme) to switch naming schemes.
> * default to current/legacy naming scheme
> * add support for a new scheme ("standard") which is consistent AWS conventions
> ** data centers will be the region name, including the number
> ** racks will be the availability zone name, including the region name
> Examples:
> * * legacy* : datacenter is the part of the availability zone name preceding the last "\-" when the zone ends in \-1 and includes the number if not \-1. Rack is the portion of the availability zone name following  the last "\-".
> ** us-west-1a => dc: us-west, rack: 1a
> ** us-west-2b => dc: us-west-2, rack: 2b; 
> * *standard* : datacenter is the part of the availability zone name preceding zone letter. rack is the entire availability zone name.
> ** us-west-1a => dc: us-west-1, rack: us-west-1a
> ** us-west-2b => dc: us-west-2, rack: us-west-2b; 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org