[GitHub] [hadoop] pranavsaxena-microsoft commented on a diff in pull request #4758: HADOOP-18408. ABFS: Setting correct value of requireRenameResilience for nonHNS configuration

[GitBox <gi...@apache.org>]

pranavsaxena-microsoft commented on code in PR #4758:
URL: https://github.com/apache/hadoop/pull/4758#discussion_r951259847


##########
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/commit/ITestAbfsRenameStageFailure.java:
##########
@@ -41,6 +42,12 @@ public ITestAbfsRenameStageFailure() throws Exception {
     binding = new ABFSContractTestBinding();
   }
 
+  protected boolean isNamespaceEnabled() {
+    FileSystem fs = getFileSystem();
+    String namespaceEnabled = fs.getConf().get("fs.azure.test.namespace.enabled");
+    return namespaceEnabled.equals("true");

Review Comment:
   [nit]:("true").equals(namespaceEnabled) is better since, namespaceEnabled can be null.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org