[GitHub] [arrow] westonpace commented on issue #35957: [C++] Confusing error with comparison operators with decimal and unsupported type

["westonpace (via GitHub)" <gi...@apache.org>]

westonpace commented on issue #35957:
URL: https://github.com/apache/arrow/issues/35957#issuecomment-1588432063

   The problem is in the `CheckDecimals` method here: https://github.com/apache/arrow/blob/apache-arrow-12.0.0/cpp/src/arrow/compute/kernels/scalar_arithmetic.cc#L649
   
   This is part of `ArithmeticFunction::DispatchBest` which attempts to implicitly cast one of the arguments to find a matching kernel (e.g. if we are doing `add(int32,int64)` then we can cast the int32 column to an int64 column).  However, we should probably be failing early if one of the types is "non-arithmetic" (arithmetic types being integer, floating, decimal, and temporal)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org