You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/06/20 09:57:53 UTC

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8681: [FLINK-12585][python] Align Stream/BatchTableEnvironment with JAVA Table API

sunjincheng121 commented on a change in pull request #8681: [FLINK-12585][python] Align Stream/BatchTableEnvironment with JAVA Table API
URL: https://github.com/apache/flink/pull/8681#discussion_r295730939
 
 

 ##########
 File path: flink-python/pyflink/table/table_config.py
 ##########
 @@ -119,7 +116,7 @@ def get_built_in_database_name(self):
         """
         return self._j_table_config.getBuiltInDatabaseName()
 
-    def _set_built_in_database_name(self, built_in_database_name):
+    def set_built_in_database_name(self, built_in_database_name):
 
 Review comment:
   Just reminder that : we should do the refactor change in a new PR. :)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services