[GitHub] [iceberg] 0xffmeta commented on a change in pull request #4152: enable stream-results option to avoid spark driver oom

[GitBox <gi...@apache.org>]

0xffmeta commented on a change in pull request #4152:
URL: https://github.com/apache/iceberg/pull/4152#discussion_r809606433



##########
File path: spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/procedures/ExpireSnapshotsProcedure.java
##########
@@ -102,6 +104,10 @@ public StructType outputType() {
         action.executeDeleteWith(executorService(maxConcurrentDeletes, "expire-snapshots"));
       }
 
+      if (streamResult) {
+        action.option("stream-results", streamResult.toString());

Review comment:
       There is one [PR](https://github.com/apache/iceberg/pull/1395) previously to collect all the results by default. This should be most usual cases. 
   The `stream-results` option should be explicitly enabled for the case that contains huge amount of data files. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org