You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@sling.apache.org by GitBox <gi...@apache.org> on 2019/12/23 12:54:02 UTC

[GitHub] [sling-org-apache-sling-distribution-journal] tmaret commented on issue #17: SLING-8932 - Redesign DistributionSubscriber to offload responsibilities

tmaret commented on issue #17: SLING-8932 - Redesign DistributionSubscriber to offload responsibilities
URL: https://github.com/apache/sling-org-apache-sling-distribution-journal/pull/17#issuecomment-568467480
 
 
   I don't have time to do a throughout review again, but the changes LGTM. 
   
   It makes much more sense to keep the three repository write ops and single commit at the same place rather than spreading this logic all over the place.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services