You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/08/11 11:34:09 UTC

[GitHub] [skywalking-infra-e2e] kezhenxu94 commented on a change in pull request #30: Some enhancements

kezhenxu94 commented on a change in pull request #30:
URL: https://github.com/apache/skywalking-infra-e2e/pull/30#discussion_r686744093



##########
File path: commands/run/run.go
##########
@@ -101,3 +90,11 @@ func runAccordingE2E() error {
 
 	return nil
 }
+
+func cleanup0() {

Review comment:
       > The function name is confusing.
   
   Because `cleanup` is already a package name, or do you prefer something like `doCleanup`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org