You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by "apeskov (via GitHub)" <gi...@apache.org> on 2023/03/15 15:53:28 UTC
[GitHub] [tvm] apeskov opened a new pull request, #14308: Hexagon compilation on MacOS system
apeskov opened a new pull request, #14308:
URL: https://github.com/apache/tvm/pull/14308
**Short desc**
This changes allow my to compile and tune models for hexagon directly from my macOS laptop without full switching to linux environment.
**List of changes**
* Replace local linker call with call from docker container with Hexagon SDK. Yes, that is the only SDK tool used by TVM during compilation.
* Enhanced search of ADB. Not only in PATH, but also in ANDROID_HOME, ANDROID_SDK_ROOT and default sdk installation directory. Mac OS doesn't allow to easily change default PATH env var for UI application launched from dock bar. So adb is not available for IDE by default.
**Motivation**
Some engineers would like to continue work with comfortable macOS environment even if they have to play with hexagon devices. At this moment there is no official Hexagon SDK for macOS system. Alternatives are next: fully switch to remote linux, use local linux virtual machine or try to introduce required hexagon SDK functionality for macOS. The last option is more preferable to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Hexagon compilation on MacOS system [tvm]
Posted by "FdyCN (via GitHub)" <gi...@apache.org>.
FdyCN commented on PR #14308:
URL: https://github.com/apache/tvm/pull/14308#issuecomment-1874970510
> **Short desc** This changes allow my to compile and tune models for hexagon directly from my macOS laptop without full switching to linux environment.
>
> **List of changes**
>
> * Replace local linker call with call from docker container with Hexagon SDK. Yes, that is the only SDK tool used by TVM during compilation.
> * Enhanced search of ADB. Not only in PATH, but also in ANDROID_HOME, ANDROID_SDK_ROOT and default sdk installation directory. Mac OS doesn't allow to easily change default PATH env var for UI application launched from dock bar. So adb is not available for IDE by default.
>
> **Motivation** Some engineers would like to continue work with comfortable macOS environment even if they have to play with hexagon devices. At this moment there is no official Hexagon SDK for macOS system. Alternatives are next: fully switch to remote linux, use local linux virtual machine or try to introduce required hexagon SDK functionality for macOS. The last option is more preferable to me.
Is there any ReadME.md to follow？I am a newbee in Hexagon, and i don't know how to use them. thanks a lot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] apeskov commented on a diff in pull request #14308: Hexagon compilation on MacOS system
Posted by "apeskov (via GitHub)" <gi...@apache.org>.
apeskov commented on code in PR #14308:
URL: https://github.com/apache/tvm/pull/14308#discussion_r1143191991
##########
python/tvm/contrib/hexagon/tools_docker_wrp.py:
##########
Review Comment:
Sure, as you wish. File name "tools_macos.py" doesn't look like perfect match with content, so I moved it to "tools.py".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] apeskov commented on a diff in pull request #14308: Hexagon compilation on MacOS system
Posted by "apeskov (via GitHub)" <gi...@apache.org>.
apeskov commented on code in PR #14308:
URL: https://github.com/apache/tvm/pull/14308#discussion_r1143186154
##########
python/tvm/tir/schedule/schedule.py:
##########
@@ -2852,7 +2852,7 @@ def transform_layout(
The buffer to be transformed, or a specification of how to
identify the buffer to be transformed.
- If `buffer` if a tuple of ``(str,int)``, the first item
+ If `buffer` is a tuple of ``(str,int)``, the first item
Review Comment:
Removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tvm-bot commented on pull request #14308: Hexagon compilation on MacOS system
Posted by "tvm-bot (via GitHub)" <gi...@apache.org>.
tvm-bot commented on PR #14308:
URL: https://github.com/apache/tvm/pull/14308#issuecomment-1470297284
<!---bot-comment-->
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
<!--bot-comment-ccs-start-->
* No users to auto-tag found, no teams are specified in PR title <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
<sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] kparzysz-quic commented on a diff in pull request #14308: Hexagon compilation on MacOS system
Posted by "kparzysz-quic (via GitHub)" <gi...@apache.org>.
kparzysz-quic commented on code in PR #14308:
URL: https://github.com/apache/tvm/pull/14308#discussion_r1137469249
##########
python/tvm/contrib/hexagon/tools_docker_wrp.py:
##########
Review Comment:
Could you either merge this code into `tools.py` or rename this file to `tools_macos.py`?
##########
python/tvm/tir/schedule/schedule.py:
##########
@@ -2852,7 +2852,7 @@ def transform_layout(
The buffer to be transformed, or a specification of how to
identify the buffer to be transformed.
- If `buffer` if a tuple of ``(str,int)``, the first item
+ If `buffer` is a tuple of ``(str,int)``, the first item
Review Comment:
This is an unrelated change, please put it in a separate PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mehrdadh merged pull request #14308: Hexagon compilation on MacOS system
Posted by "mehrdadh (via GitHub)" <gi...@apache.org>.
mehrdadh merged PR #14308:
URL: https://github.com/apache/tvm/pull/14308
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org