[jira] [Commented] (FLINK-6763) Inefficient PojoSerializerConfigSnapshot serialization format

["Tzu-Li (Gordon) Tai (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-6763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16038408#comment-16038408 ] 

Tzu-Li (Gordon) Tai commented on FLINK-6763:
--------------------------------------------

After an offline discussion with [~till.rohrmann], we decided not to include this fix for 1.3.1 and only for 1.4.0.
The reason is that we shouldn't break serialization formats across minor releases.
I'll de-label the "1.3 release blocker" tag for this JIRA.

> Inefficient PojoSerializerConfigSnapshot serialization format
> -------------------------------------------------------------
>
>                 Key: FLINK-6763
>                 URL: https://issues.apache.org/jira/browse/FLINK-6763
>             Project: Flink
>          Issue Type: Improvement
>          Components: State Backends, Checkpointing, Type Serialization System
>    Affects Versions: 1.3.0, 1.4.0
>            Reporter: Till Rohrmann
>            Assignee: Tzu-Li (Gordon) Tai
>              Labels: flink-rel-1.3.1-blockers
>
> The {{PojoSerializerConfigSnapshot}} stores for each serializer the beginning offset and ending offset in the serialization stream. This information is also written if the serializer serialization is supposed to be ignored. The beginning and ending offsets are stored as a sequence of integers at the beginning of the serialization stream. We store this information to skip broken serializers.
> I think we don't need both offsets. Instead I would suggest to write the length of the serialized serializer first into the serialization stream and then the serialized serializer. This can be done in {{TypeSerializerSerializationUtil.writeSerializer}}. When reading the serializer via {{TypeSerializerSerializationUtil.tryReadSerializer}}, we can try to deserialize the serializer. If this operation fails, then we can skip the number of serialized serializer because we know how long it was.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)