You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2018/12/19 18:45:27 UTC
[GitHub] ocket8888 commented on a change in pull request #3140: Add traffic_ops_ort.pl suuport for processing ##OVERRIDE## lines from…
ocket8888 commented on a change in pull request #3140: Add traffic_ops_ort.pl suuport for processing ##OVERRIDE## lines from…
URL: https://github.com/apache/trafficcontrol/pull/3140#discussion_r243031462
##########
File path: traffic_ops/bin/traffic_ops_ort.pl
##########
@@ -303,12 +303,12 @@ sub revalidate_while_sleeping {
}
sub os_version {
- my $release = "UNKNOWN";
- if (`uname -r` =~ m/.+(el\d)(?:\.\w+)*\.x86_64/) {
- $release = uc $1;
- }
- exists $supported_el_release{$release} ? return $release
- : die("unsupported el_version: $release");
+ my $release = "UNKNOWN";
+ if (`uname -r` =~ m/.+(el\d)(?:\.\w+)*\.x86_64/) {
+ $release = uc $1;
+ }
+ exists $supported_el_release{$release} ? return $release
+ : die("unsupported el_version: $release");
Review comment:
First let me say I'm a huge fan of turning space-based indentation into tab-based indentation. Just be careful that when you're doing that you aren't turning _alignment_ into _indentation_. This should be indented one level with a tab character then aligned using spaces so that it displays consistently regardless of where your editor places its tabstops.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services