DO NOT REPLY [Bug 9576] - [PATCH] xls import into MS Access 97 does not work

[bu...@apache.org]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=9576>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=9576

[PATCH] xls import into MS Access 97 does not work

jheight@subcorp.com.au changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |ASSIGNED
            Summary|xls import into MS Access 97|[PATCH] xls import into MS
                   |does not work               |Access 97 does not work



------- Additional Comments From jheight@subcorp.com.au  2003-01-31 11:02 -------
OK I see now why the DBCell and Index functionality hasnt been done up to 
now.. It was a real pain (but i still had fun doing it, well actually only 
when it started to work ;-)

This is a large patch so suggestions are welcome. 

There are some issues that I think need to be cleaned up after this patch is 
accepted, but i was thinking that i could include another patch at a later 
date if it is agreed that these issues should be resolved:
1) Removal of the old code that attempted to do this work from 
RowRecordsAggregate.
2) RowRecordsAggregate and ValueRecordsAggregate.serialize is no longer called 
so they can be removed.
3) I dont understand the need for the serialize method that returns the byte 
array. Since this doesnt seem to be called. (Although i could be wrong on this 
one, i didnt spend alot of time on it)
4) A unit test for this (although basically the unit tests that write a set of 
rows will already test these changes)
5) The lookup of rows from the RowRecordsAggregate and cells from 
ValueRecordAggregate seems sub optimal in certain situations (see comments in 
patch)

The patch will create the DBCell and Index records in the output stream but 
for most people to this point they have lived without this functionality. 
Maybe there should be a flag for the Sheet that tells it whether to write 
these records or not?

Thanks

Jason